Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make RelationalCompiledQueryCacheKeyGenerator really public #15442

Closed
ajcvickers opened this issue Apr 22, 2019 · 0 comments · Fixed by #15452
Closed

Make RelationalCompiledQueryCacheKeyGenerator really public #15442

ajcvickers opened this issue Apr 22, 2019 · 0 comments · Fixed by #15452
Labels
closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-enhancement
Milestone
3.0.0

Comments

@ajcvickers
Copy link
Member

It's in a public namespace, but all usages are marked internal, which makes it impossible for other providers to extend from without using internal code. (Looks like this is primary a docs issue.)
@ajcvickers ajcvickers self-assigned this Apr 22, 2019
@ajcvickers ajcvickers added this to the 3.0.0 milestone Apr 22, 2019
@ajcvickers ajcvickers mentioned this issue Apr 22, 2019
Closed
ajcvickers added a commit that referenced this issue Apr 22, 2019
@ajcvickers
Make more internal code public
32a7833 
This is mostly adding proper docs to things that should be public but were still documented as internal. Also moved a few types accordingly, and made a few things really internal or private.

Fixes #15442
Fixes #15441
Fixes #15107
ajcvickers added a commit that referenced this issue Apr 22, 2019
@ajcvickers
Make more internal code public
582f7d2 
This is mostly adding proper docs to things that should be public but were still documented as internal. Also moved a few types accordingly and made a few things really internal or private.

Fixes #15442
Fixes #15441
Fixes #15107
@ajcvickers ajcvickers mentioned this issue Apr 22, 2019
Merged
@ajcvickers ajcvickers added the closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. label Apr 22, 2019
ajcvickers added a commit that referenced this issue Apr 23, 2019
@ajcvickers
Make more internal code public
2e5a432 
This is mostly adding proper docs to things that should be public but were still documented as internal. Also moved a few types accordingly and made a few things really internal or private.

Fixes #15442
Fixes #15441
Fixes #15107
@ajcvickers ajcvickers modified the milestones: 3.0.0, 3.0.0-preview6 Jun 5, 2019
@ajcvickers ajcvickers modified the milestones: 3.0.0-preview6, 3.0.0 Nov 11, 2019
@ajcvickers ajcvickers removed their assignment Sep 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-enhancement
Projects
None yet
Milestone
3.0.0
Development

Successfully merging a pull request may close this issue.

Make more internal code public dotnet/efcore
1 participant
@ajcvickers