Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review individual members documented as internal #15107

Closed
ajcvickers opened this issue Mar 21, 2019 · 1 comment · Fixed by #16706
Closed

Review individual members documented as internal #15107

ajcvickers opened this issue Mar 21, 2019 · 1 comment · Fixed by #16706
Assignees
@smitpatel
Labels
closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-enhancement
Milestone
3.0.0

Comments

@ajcvickers
Copy link
Member

Some may be able to be made public now.
@ajcvickers ajcvickers self-assigned this Mar 21, 2019
@ajcvickers ajcvickers mentioned this issue Mar 21, 2019
Merged
@ajcvickers ajcvickers added this to the 3.0.0 milestone Mar 22, 2019
ajcvickers added a commit that referenced this issue Apr 22, 2019
@ajcvickers
Make more internal code public
32a7833 
This is mostly adding proper docs to things that should be public but were still documented as internal. Also moved a few types accordingly, and made a few things really internal or private.

Fixes #15442
Fixes #15441
Fixes #15107
ajcvickers added a commit that referenced this issue Apr 22, 2019
@ajcvickers
Make more internal code public
582f7d2 
This is mostly adding proper docs to things that should be public but were still documented as internal. Also moved a few types accordingly and made a few things really internal or private.

Fixes #15442
Fixes #15441
Fixes #15107
@ajcvickers ajcvickers mentioned this issue Apr 22, 2019
Merged
@ajcvickers
Copy link
Member Author

Done for all but conventions/builders. Also, query may need re-doing once the overhaul is merged.

@ajcvickers ajcvickers reopened this Apr 23, 2019
@ajcvickers ajcvickers added the closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. label Jul 23, 2019
ajcvickers added a commit that referenced this issue Jul 23, 2019
@ajcvickers
Query API review changes
3959fd9 
Mostly moving types to different namespaces (internal or public), and a few renames.

Also, checked where Cosmos and other providers were using internal types and made those pubic.

Re-enabled API consistency, except for NotNull attributes (since these aren't breaking to add later.)

Fixes #12084
Fixes #15107
Fixes #15695
Fixes #15796
@ajcvickers ajcvickers mentioned this issue Jul 23, 2019
Merged
ajcvickers added a commit that referenced this issue Jul 23, 2019
@ajcvickers
Query API review changes
af70174 
Mostly moving types to different namespaces (internal or public), and a few renames.

Also, checked where Cosmos and other providers were using internal types and made those pubic.

Re-enabled API consistency, except for NotNull attributes (since these aren't breaking to add later.)

Fixes #12084
Fixes #15107
Fixes #15695
Fixes #15796
@ajcvickers ajcvickers modified the milestones: 3.0.0, 3.0.0-preview8 Jul 29, 2019
@ajcvickers ajcvickers modified the milestones: 3.0.0-preview8, 3.0.0 Nov 11, 2019
@AndriySvyryd AndriySvyryd removed their assignment Mar 6, 2020
@ajcvickers ajcvickers removed their assignment Sep 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@smitpatel smitpatel

Labels
closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-enhancement
Projects
None yet
Milestone
3.0.0
Development

Successfully merging a pull request may close this issue.

Query API review changes dotnet/efcore
3 participants
@ajcvickers @smitpatel @AndriySvyryd