Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy endpoint info, runtime info, commmand parsing, and tests from dotnet/diagnostics #451

Merged
merged 6 commits into from
Jun 18, 2021

Conversation

jander-msft
Copy link
Member

These changes move some source from the diagnostics repo to dotnet-monitor. This is done because the endpoint info (and related) classes are not used by the other diagnostic tools and allows dotnet-monitor to eventually refactor some of the abstracts into simpler forms. This change is the first step of just porting the code from diagnostics to dotnet-monitor without changing any of the functionality. Some of the test code was changed in order to fit the existing test expectations in this repository.

cc @josalem, @hoyosjs

@hoyosjs
Copy link
Member

hoyosjs commented Jun 16, 2021

I am happy with this living here. However, does this affect in any way the triggers + channels functionality that was proposed? The ASP.NET Core library that was proposed at some point could live here with no issues.

@jander-msft
Copy link
Member Author

I am happy with this living here. However, does this affect in any way the triggers + channels functionality that was proposed? The ASP.NET Core library that was proposed at some point could live here with no issues.

Chatted offline, but putting it here for everyone else. The pipeline implementations will remain in the diagnostics repo. The triggers feature will be partially implemented in the diagnostics repo (the pipeline and trigger conditions) and partially in dotnet-monitor (configuration of trigger conditions with actions and filters). The web API library will likely remain in the dotnet-monitor repo.

@jander-msft jander-msft merged commit deb715e into dotnet:main Jun 18, 2021
@jander-msft jander-msft deleted the dev/jander/endpoint-info-move branch June 18, 2021 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants