Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove endpoint info, runtime info, and command line helper. #2371

Merged

Conversation

jander-msft
Copy link
Member

These types are moving to the dotnet-monitor repo since the other diagnostic tools do not use them, we don't anticipate that they will use them, and allows dotnet-monitor to simplify the abstractions that it has in place due to the separation across the repos. The PR to move them to dotnet-monitor is dotnet/dotnet-monitor#451

cc @josalem, @hoyosjs

@jander-msft
Copy link
Member Author

@dotnet/dotnet-diag : Could I get approval on this? The PR to copy these to dotnet-monitor has been merged: dotnet/dotnet-monitor#451

@josalem
Copy link
Contributor

josalem commented Jun 30, 2021

Before we remove this code -- @lateralusX don't you use some of these types in dsrouter?

@jander-msft
Copy link
Member Author

Before we remove this code -- @lateralusX don't you use some of these types in dsrouter?

I didn't find any code usage unless it is being used via reflection. But a cursory look says that it is not used.

dsrouter does use IpcEndpointInfo which is in NETCore.Client assembly, but that is a different type than the IEndpiontInfo interface and *EndpointInfoSource types.

Copy link
Contributor

@josalem josalem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If there isn't any usage outside dotnet-monitor, I'm okay removing this code since it's already in the dotnet-monitor repo.

@jander-msft jander-msft merged commit 7f2fffa into dotnet:main Jul 1, 2021
@jander-msft jander-msft deleted the dev/jander/remove-endpoint-info branch July 1, 2021 04:19
@github-actions github-actions bot locked and limited conversation to collaborators Jan 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants