Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements around DBNull.Value for DataRowExtensions #9080

Merged
merged 1 commit into from
Jun 23, 2023

Conversation

roji
Copy link
Member

@roji roji commented Jun 16, 2023

Closes #9077

@ghost ghost assigned roji Jun 16, 2023
@dotnet-issue-labeler dotnet-issue-labeler bot added the area-System.Data Data APIs (ADO.NET, XML, etc). label Jun 16, 2023
@ghost
Copy link

ghost commented Jun 16, 2023

Tagging subscribers to this area: @roji, @ajcvickers
See info in area-owners.md if you want to be subscribed.

Issue Details

Closes #9077

Author: roji
Assignees: roji
Labels:

area-System.Data

Milestone: -

@learn-build-service-prod
Copy link

Learn Build status updates of commit f6e6e9b:

✅ Validation status: passed

File Status Preview URL Details
xml/System.Data/DataRowExtensions.xml ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

@JRahnama
Copy link

LGTM, just a minor question, : according to the comment from VS team in issue #2013 at SqlClient cref should be used instead of xref. That is going to be a lot of work to updated the entire documentation, but we can stop adding more to it I think. Again this is going to be huge. For example, instead of CDATA, each paragraph should be wrapped in <para>[content]</para> tags and some other modifications. I am just wondering if we should start following that path to prevent more changes to convert in future?

@roji
Copy link
Member Author

roji commented Jun 19, 2023

@JRahnama I'm not an expert on the doc system - someone more proficient there should probably answer. But if indeed a fundamental change like that needs to be done, I think it would be better to do that in a separate dedicated PR that does everything.. This PR really is unrelated to that, and changing things here would lead to an inconsistent state where we don't do the same thing everywhere..

@roji roji merged commit 16f56af into dotnet:main Jun 23, 2023
@roji roji deleted the DataRowExtensions branch June 23, 2023 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-System.Data Data APIs (ADO.NET, XML, etc).
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DataRowExtensions "nullable types" support clarity.
3 participants