Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CDATA Block is not formatter correctly in VS #2013

Closed
YuryKomar opened this issue Apr 20, 2023 · 8 comments · Fixed by #2822 or #2834
Closed

CDATA Block is not formatter correctly in VS #2013

YuryKomar opened this issue Apr 20, 2023 · 8 comments · Fixed by #2822 or #2834
Assignees

Comments

@YuryKomar
Copy link

YuryKomar commented Apr 20, 2023

The function descriprion includes a comment CDATA block is not completely formatted in Visual Studio. I mean the XREF hyperlink, it stil visible in popup...

Will it be fixed?

see attached image
Снимок
SqlClient Info

@JRahnama JRahnama added the 🆕 Triage Needed For new issues, not triaged yet. label Apr 20, 2023
@JRahnama JRahnama removed the 🆕 Triage Needed For new issues, not triaged yet. label Apr 25, 2023
@JRahnama JRahnama self-assigned this Apr 25, 2023
@JRahnama
Copy link
Contributor

We will check this with VS team and will get back to you.

@arunchndr
Copy link
Member

Moved to the right repo via dotnet/roslyn#68134. Feel free to close this one.

@JRahnama JRahnama added the 🔗 External Issue is in an external component label May 9, 2023
@JRahnama
Copy link
Contributor

JRahnama commented May 9, 2023

Thank you @arkalyanms. @YuryKomar you can follow this on roslyn repo. Closing this as an external issue.

@JRahnama JRahnama closed this as completed May 9, 2023
@sharwell
Copy link
Member

sharwell commented May 14, 2023

The rendering of this comment is an accurate reflection of the content provided here:

<remarks>
<format type="text/markdown"><![CDATA[
## Remarks
When an instance of <xref:Microsoft.Data.SqlClient.SqlCommand> is created, the read/write properties are set to their initial values. For a list of these values, see the <xref:Microsoft.Data.SqlClient.SqlCommand> constructor.
<xref:Microsoft.Data.SqlClient.SqlCommand> features the following methods for executing commands at a SQL Server database:
|Item|Description|
|----------|-----------------|
|<xref:Microsoft.Data.SqlClient.SqlCommand.BeginExecuteNonQuery%2A>|Initiates the asynchronous execution of the Transact-SQL statement or stored procedure that is described by this <xref:Microsoft.Data.SqlClient.SqlCommand>, generally executing commands such as INSERT, DELETE, UPDATE, and SET statements. Each call to <xref:Microsoft.Data.SqlClient.SqlCommand.BeginExecuteNonQuery%2A> must be paired with a call to <xref:Microsoft.Data.SqlClient.SqlCommand.EndExecuteNonQuery%2A> which finishes the operation, typically on a separate thread.|
|<xref:Microsoft.Data.SqlClient.SqlCommand.BeginExecuteReader%2A>|Initiates the asynchronous execution of the Transact-SQL statement or stored procedure that is described by this <xref:Microsoft.Data.SqlClient.SqlCommand> and retrieves one or more results sets from the server. Each call to <xref:Microsoft.Data.SqlClient.SqlCommand.BeginExecuteReader%2A> must be paired with a call to <xref:Microsoft.Data.SqlClient.SqlCommand.EndExecuteReader%2A> which finishes the operation, typically on a separate thread.|
|<xref:Microsoft.Data.SqlClient.SqlCommand.BeginExecuteXmlReader%2A>|Initiates the asynchronous execution of the Transact-SQL statement or stored procedure that is described by this <xref:Microsoft.Data.SqlClient.SqlCommand>. Each call to `BeginExecuteXmlReader` must be paired with a call to `EndExecuteXmlReader`, which finishes the operation, typically on a separate thread, and returns an <xref:System.Xml.XmlReader> object.|
|<xref:Microsoft.Data.SqlClient.SqlCommand.ExecuteReader%2A>|Executes commands that return rows. For increased performance, <xref:Microsoft.Data.SqlClient.SqlCommand.ExecuteReader%2A> invokes commands using the Transact-SQL `sp_executesql` system stored procedure. Therefore, <xref:Microsoft.Data.SqlClient.SqlCommand.ExecuteReader%2A> might not have the effect that you want if used to execute commands such as Transact-SQL SET statements.|
|<xref:Microsoft.Data.SqlClient.SqlCommand.ExecuteNonQuery%2A>|Executes commands such as Transact-SQL INSERT, DELETE, UPDATE, and SET statements.|
|<xref:Microsoft.Data.SqlClient.SqlCommand.ExecuteScalar%2A>|Retrieves a single value (for example, an aggregate value) from a database.|
|<xref:Microsoft.Data.SqlClient.SqlCommand.ExecuteXmlReader%2A>|Sends the <xref:Microsoft.Data.SqlClient.SqlCommand.CommandText%2A> to the <xref:Microsoft.Data.SqlClient.SqlCommand.Connection%2A> and builds an <xref:System.Xml.XmlReader> object.|
You can reset the <xref:Microsoft.Data.SqlClient.SqlCommand.CommandText%2A> property and reuse the <xref:Microsoft.Data.SqlClient.SqlCommand> object. However, you must close the <xref:Microsoft.Data.SqlClient.SqlDataReader> before you can execute a new or previous command.
If a <xref:Microsoft.Data.SqlClient.SqlException> is generated by the method executing a <xref:Microsoft.Data.SqlClient.SqlCommand>, the <xref:Microsoft.Data.SqlClient.SqlConnection> remains open when the severity level is 19 or less. When the severity level is 20 or greater, the server ordinarily closes the <xref:Microsoft.Data.SqlClient.SqlConnection>. However, the user can reopen the connection and continue.
> [!NOTE]
> Nameless, also called ordinal, parameters are not supported by the .NET Framework Data Provider for SQL Server.
## Examples
The following example creates a <xref:Microsoft.Data.SqlClient.SqlConnection>, a <xref:Microsoft.Data.SqlClient.SqlCommand>, and a <xref:Microsoft.Data.SqlClient.SqlDataReader>. The example reads through the data, writing it to the console. Finally, the example closes the <xref:Microsoft.Data.SqlClient.SqlDataReader> and then the <xref:Microsoft.Data.SqlClient.SqlConnection> as it exits the `Using` code blocks.
[!code-csharp[SqlCommand Example#1](~/../sqlclient/doc/samples/SqlCommand.cs#1)]
The following sample shows how to create and execute different types of SqlCommand objects.
First you must create the sample database, by executing the following script:
[!code-sql[Setup Database](~/../sqlclient/doc/samples/SqlCommand_Setup.sql#1)]
Next, compile and execute the following:
[!code-csharp[SqlCommand Example#2](~/../sqlclient/doc/samples/SqlCommand_Intro.cs#1)]
]]></format>
</remarks>

Note that <format type="text/markdown"> is not a recognized content for documentation comments, so the contents of this element will be rendered the same way as if the content was written inline (i.e. not surrounded by the <format> element).

There are no immediate plans to change the language behavior here, but there is an issue filed with a very broad feature request for it: dotnet/csharplang#2394

Some of the changes required include the following. Other changes may be needed as well.

  • Removing the <format type="text/markdown"> element
  • Wrapping each paragraph in <para>[content]</para>
  • Converting all <xref> elements to <see cref="[target]"/>
  • Converting the table to <list type="table">

@JRahnama JRahnama reopened this May 14, 2023
@JRahnama JRahnama added 🆕 Triage Needed For new issues, not triaged yet. and removed 🔗 External Issue is in an external component 🆕 Triage Needed For new issues, not triaged yet. labels May 17, 2023
@JRahnama JRahnama removed their assignment Jul 7, 2024
@benrr101 benrr101 self-assigned this Aug 27, 2024
@JRahnama
Copy link
Contributor

JRahnama commented Sep 5, 2024

This is to inform you that work is currently in progress to resolve the issue. The first PR has been merged, and the remaining updates will follow shortly.

@benrr101
Copy link
Contributor

At long last, the batches have been completed, and the docs have been restructured into XML format. There are a couple follow up tasks, but the bulk of the work is complete.

@benrr101
Copy link
Contributor

(also I guess I messed up by linking the issue to the PR and it auto-closed it...)

@JRahnama
Copy link
Contributor

(also I guess I messed up by linking the issue to the PR and it auto-closed it...)

I think this is fine/correct., as the issue is addressed/being addressed in several PRs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants