Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: always copy template resources before build #8522

Merged
merged 1 commit into from
Mar 17, 2023
Merged

Conversation

yufeih
Copy link
Contributor

@yufeih yufeih commented Mar 17, 2023

#8510 uses an unreliable way of fixing #8500 by ignoring files already on disk. It causes side effects such as template not updating when _site was built previously.

This PR attempts to fix #8500 by copy templates before building resources.

@codecov
Copy link

codecov bot commented Mar 17, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.02 🎉

Comparison is base (86c61f7) 76.26% compared to head (d72eb38) 76.29%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8522      +/-   ##
==========================================
+ Coverage   76.26%   76.29%   +0.02%     
==========================================
  Files         858      858              
  Lines       30647    30639       -8     
==========================================
+ Hits        23374    23377       +3     
+ Misses       7273     7262      -11     
Impacted Files Coverage Δ
...ft.DocAsCode.Build.Engine/SingleDocumentBuilder.cs 82.41% <100.00%> (+0.09%) ⬆️
...ild.Engine/TemplateProcessors/TemplateProcessor.cs 87.87% <100.00%> (-0.13%) ⬇️

... and 6 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@yufeih yufeih marked this pull request as ready for review March 17, 2023 07:48
@yufeih yufeih merged commit f5f0ec6 into main Mar 17, 2023
@yufeih yufeih deleted the copy-template-resource branch March 17, 2023 08:03
@yufeih yufeih added the bug-fix Makes the pull request to appear in "Bug Fixes" section of the next release note label Mar 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug-fix Makes the pull request to appear in "Bug Fixes" section of the next release note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Custom logo and favicon ignored
1 participant