Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: custom logo not override logo from template #8510

Merged
merged 1 commit into from
Mar 13, 2023
Merged

fix: custom logo not override logo from template #8510

merged 1 commit into from
Mar 13, 2023

Conversation

yufeih
Copy link
Contributor

@yufeih yufeih commented Mar 13, 2023

fixes #8500

@yufeih yufeih added the bug-fix Makes the pull request to appear in "Bug Fixes" section of the next release note label Mar 13, 2023
@codecov
Copy link

codecov bot commented Mar 13, 2023

Codecov Report

Patch coverage: 66.66% and project coverage change: +0.09 🎉

Comparison is base (4a1e32d) 76.18% compared to head (918b772) 76.27%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8510      +/-   ##
==========================================
+ Coverage   76.18%   76.27%   +0.09%     
==========================================
  Files         858      858              
  Lines       30644    30647       +3     
==========================================
+ Hits        23345    23375      +30     
+ Misses       7299     7272      -27     
Impacted Files Coverage Δ
src/Microsoft.DocAsCode.App/RunServe.cs 0.00% <0.00%> (ø)
src/Microsoft.DocAsCode.App/Docset.cs 100.00% <100.00%> (+100.00%) ⬆️
...ild.Engine/TemplateProcessors/TemplateProcessor.cs 88.00% <100.00%> (+0.50%) ⬆️

... and 5 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@yufeih yufeih marked this pull request as ready for review March 13, 2023 12:50
@yufeih yufeih merged commit 27a1e18 into main Mar 13, 2023
@yufeih yufeih deleted the fix-logo branch March 13, 2023 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug-fix Makes the pull request to appear in "Bug Fixes" section of the next release note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Custom logo and favicon ignored
1 participant