Use PEImage API get export symbols for single file apps #2674
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add single file app testing support. Disable bpmd testing for single-file on Linux/MacOS Issues: dotnet#2515 and dotnet#2438
IDebuggerServices::GetOffsetBySymbol is used to get the runtime info export and so most of the changes are making the interface available on the libsos "side" under Linux/MacOS since there is a Extensions instance both in libsosplugin and libsos. The libsos side Extensions::GetDebuggerServices always returned null before this change. Now it only returns null if hosted under a managed host like dotnet-dump.
Simplify to what the managed Runtime code does without the debugshim and library provider. SOS no longer needs debugshim, but left it for the future dbgshim out-of-band work.
hoyosjs
reviewed
Oct 18, 2021
src/SOS/SOS.UnitTests/Debuggees/SymbolTestApp/SymbolTestApp/SymbolTestApp.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Diagnostics.DebugServices.Implementation/ModuleServiceFromDataReader.cs
Show resolved
Hide resolved
mikem8361
commented
Oct 18, 2021
src/Microsoft.Diagnostics.DebugServices.Implementation/ModuleServiceFromDataReader.cs
Show resolved
Hide resolved
src/SOS/SOS.UnitTests/Debuggees/SymbolTestApp/SymbolTestApp/SymbolTestApp.cs
Outdated
Show resolved
Hide resolved
|
I did comment.
|
hoyosjs
approved these changes
Oct 18, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add single file app testing support.
Disable bpmd testing for single-file on Linux/MacOS
Issues: #2515 and #2438