-
Notifications
You must be signed in to change notification settings - Fork 357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Watson support for single-file apps #2438
Comments
Tagging subscribers to this area: @agocke, @vitek-karas, @VSadov Issue DetailsWe should support automatically creating dumps from single-file apps, and automatically analyzing the dumps created from those crashes.
|
Tagging subscribers to this area: @tommcdon Issue DetailsWe should support automatically creating dumps from single-file apps, and automatically analyzing the dumps created from those crashes.
|
This should work with Windows Watson right now, provided that they configure collecting dumps on crash. Createdump on both platforms (and therefore environment variables) won't work as the binary won't be present. |
I believe SOS work is completed for Windows single file dumps. Adding @mikem8361. |
We still have work in the CLRMD PE reader and runtime enumeration to look up exports because the current runtime enumeration is too slow for even regular non-single apps so it is enabled under an env var called DOTNET_ENABLE_SOS_SINGLEFILE=1 |
But that is all out of band and in the clrmd/diagnostics repos. |
Add single file app testing support. Disable bpmd testing for single-file on Linux/MacOS Issues: dotnet#2515 and dotnet#2438
Other than ingestion from the Watson folks, and your PR, is there anything missing here @mikem8361? |
To be complete, there will be one more item to do (it is part of #2515: Add Windows single-file support to the fallback runtime enumeration in platform/targetimpl.cpp. Need C++ to lookup PE exports. I'm really not sure how important the C++ fallback is other than perf since we support using the desktop framework to host. |
* Use PEImage API get export symbols for single file apps Add single file app testing support. Disable bpmd testing for single-file on Linux/MacOS Issues: #2515 and #2438 * Support Windows/MacOS single-file in the C++ runtime enum fallback IDebuggerServices::GetOffsetBySymbol is used to get the runtime info export and so most of the changes are making the interface available on the libsos "side" under Linux/MacOS since there is a Extensions instance both in libsosplugin and libsos. The libsos side Extensions::GetDebuggerServices always returned null before this change. Now it only returns null if hosted under a managed host like dotnet-dump. * Disable test single-file live apps on Alpine * Enable single-file tests when no host runtime (C++ fallback) * Fix initialize bpmd problems on Main * Fix clrstack -i/ICorDebug C++ fallback code for single-file Simplify to what the managed Runtime code does without the debugshim and library provider. SOS no longer needs debugshim, but left it for the future dbgshim out-of-band work.
The C++ runtime enumeration fallback code will work for Windows single-file because it uses GetOffsetBySymbol to find export. |
We should support automatically creating dumps from single-file apps, and automatically analyzing the dumps created from those crashes.
The text was updated successfully, but these errors were encountered: