Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disabling EventLogsPipeUnitTests.TestLogsWildcardCategory and EventCounterTriggerTests.EventCounterTriggerWithEventPipePipelineTest #2569

Merged
4 commits merged into from
Sep 8, 2021
Merged

Disabling EventLogsPipeUnitTests.TestLogsWildcardCategory and EventCounterTriggerTests.EventCounterTriggerWithEventPipePipelineTest #2569

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c34d091
Disabling EventLogsPipeUnitTests.TestLogsWildcardCategory and EventCo…
mikem8361 Sep 8, 2021
ac96268
Only skip on Windows
mikem8361 Sep 8, 2021
ead30fa
Disabled EventLogsPipelineUnitTests.TestLogsAllCategoriesAllLevels fo…
mikem8361 Sep 8, 2021
1a6c180
Disable an unreliable SOS test on MacOS (https://github.com/dotnet/di…
mikem8361 Sep 8, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/tests/Microsoft.Diagnostics.Monitoring.EventPipe/EventCounterTriggerTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -313,8 +313,10 @@ public void EventCounterTriggerDropTest()
/// Tests that the trigger condition can be detected on a live application
/// using the EventPipeTriggerPipeline.
/// </summary>
[Fact]
public async Task EventCounterTriggerWithEventPipePipelineTest()
//https://github.com/dotnet/diagnostics/issues/2568
//[Fact]
//public async Task EventCounterTriggerWithEventPipePipelineTest()
private async Task EventCounterTriggerWithEventPipePipelineTest()
{
EventCounterTriggerSettings settings = new()
{
Expand Down
6 changes: 4 additions & 2 deletions src/tests/Microsoft.Diagnostics.Monitoring.EventPipe/EventLogsPipelineUnitTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -181,8 +181,10 @@ public async Task TestLogsUseAppFiltersAndFilterSpecs()
/// <summary>
/// Test that log events are collected for wildcard categories.
/// </summary>
[Fact]
public async Task TestLogsWildcardCategory()
//https://github.com/dotnet/diagnostics/issues/2568
//[Fact]
//public async Task TestLogsWildcardCategory()
private async Task TestLogsWildcardCategory()
mikem8361 marked this conversation as resolved.
Show resolved Hide resolved
{
using Stream outputStream = await GetLogsAsync(settings =>
{
Expand Down