Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disabling EventLogsPipeUnitTests.TestLogsWildcardCategory and EventCounterTriggerTests.EventCounterTriggerWithEventPipePipelineTest #2569

Merged
4 commits merged into from
Sep 8, 2021
Merged

Disabling EventLogsPipeUnitTests.TestLogsWildcardCategory and EventCounterTriggerTests.EventCounterTriggerWithEventPipePipelineTest #2569

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c34d091
Disabling EventLogsPipeUnitTests.TestLogsWildcardCategory and EventCo…
mikem8361 Sep 8, 2021
ac96268
Only skip on Windows
mikem8361 Sep 8, 2021
ead30fa
Disabled EventLogsPipelineUnitTests.TestLogsAllCategoriesAllLevels fo…
mikem8361 Sep 8, 2021
1a6c180
Disable an unreliable SOS test on MacOS (https://github.com/dotnet/di…
mikem8361 Sep 8, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion src/SOS/SOS.UnitTests/Scripts/GCTests.script
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,6 +158,11 @@ VERIFY:Break instruction exception - code 80000003
ENDIF:CDB

SOSCOMMAND:EEHeap -gc

# DumpStackObjects does not work here on 6.0 MacOS
# https://github.com/dotnet/diagnostics/issues/1950
!IFDEF:OSX

SOSCOMMAND:DumpStackObjects
SOSCOMMAND:GCWhere <POUT>\w+\s+(<HEXVAL>)\s+([Gg][Cc]where!\$0_)*GCWhere\s+<POUT>
# we care that the Gen is 2
Expand All @@ -167,17 +172,20 @@ SOSCOMMAND:GCRoot <PREVPOUT>
VERIFY:.*Thread <HEXVAL>:
VERIFY:\s+<HEXVAL>\s+<HEXVAL>\s+GCWhere\.Main\(\)\s+\[.*[/|\\][Gg][Cc][Ww]here\.cs\s+@\s+45\]\s+

ENDIF:OSX

# Continue to the next DebugBreak
CONTINUE
IFDEF:CDB
VERIFY:Break instruction exception - code 80000003
ENDIF:CDB

SOSCOMMAND:EEHeap -gc

# DumpStackObjects does not work here on 6.0 MacOS
# https://github.com/dotnet/diagnostics/issues/1950
!IFDEF:OSX

SOSCOMMAND:EEHeap -gc
SOSCOMMAND:DumpStackObjects
SOSCOMMAND:GCWhere <POUT>\w+\s+(<HEXVAL>)\s+([Gg][Cc]where!\$0_)*GCWhere\s+<POUT>
# we care that the Gen is still 2 or 0 on Windows 3.x
Expand Down
8 changes: 7 additions & 1 deletion src/tests/Microsoft.Diagnostics.Monitoring.EventPipe/EventCounterTriggerTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,10 +9,12 @@
using System;
using System.ComponentModel.DataAnnotations;
using System.Globalization;
using System.Runtime.InteropServices;
using System.Threading;
using System.Threading.Tasks;
using Xunit;
using Xunit.Abstractions;
using Xunit.Extensions;

namespace Microsoft.Diagnostics.Monitoring.EventPipe.UnitTests
{
Expand Down Expand Up @@ -313,9 +315,13 @@ public void EventCounterTriggerDropTest()
/// Tests that the trigger condition can be detected on a live application
/// using the EventPipeTriggerPipeline.
/// </summary>
[Fact]
[SkippableFact]
public async Task EventCounterTriggerWithEventPipePipelineTest()
{
if (RuntimeInformation.IsOSPlatform(OSPlatform.Windows))
{
throw new SkipTestException("https://github.com/dotnet/diagnostics/issues/2568");
}
EventCounterTriggerSettings settings = new()
{
ProviderName = EventCounterConstants.RuntimeProviderName,
Expand Down
13 changes: 11 additions & 2 deletions src/tests/Microsoft.Diagnostics.Monitoring.EventPipe/EventLogsPipelineUnitTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,9 +34,14 @@ public EventLogsPipelineUnitTests(ITestOutputHelper output)
/// <summary>
/// Test that all log events are collected if no filters are specified.
/// </summary>
[Fact]
[SkippableFact]
public async Task TestLogsAllCategoriesAllLevels()
{
if (RuntimeInformation.IsOSPlatform(OSPlatform.Windows))
{
throw new SkipTestException("https://github.com/dotnet/diagnostics/issues/2541");
}

using Stream outputStream = await GetLogsAsync(settings =>
{
settings.UseAppFilters = false;
Expand Down Expand Up @@ -181,9 +186,13 @@ public async Task TestLogsUseAppFiltersAndFilterSpecs()
/// <summary>
/// Test that log events are collected for wildcard categories.
/// </summary>
[Fact]
[SkippableFact]
public async Task TestLogsWildcardCategory()
{
if (RuntimeInformation.IsOSPlatform(OSPlatform.Windows))
{
throw new SkipTestException("https://github.com/dotnet/diagnostics/issues/2568");
}
using Stream outputStream = await GetLogsAsync(settings =>
{
settings.UseAppFilters = false;
Expand Down