Avoid checking for ephemeral heap segment in DumpGen #2501
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikem8361
approved these changes
Aug 12, 2021
hoyosjs
added a commit
that referenced
this pull request
Sep 30, 2021
* fixed dotnet-trace when output is not redirected (#2448) Co-authored-by: Mikelle Rogers <[email protected]> * [main] Update dependencies from dotnet/runtime (#2435) * Fix asssuption in SOS what the IXClrDataModule::GetFlags returns. * Update to lldb-included Alpine 3.13 container * Try node image for agent comms * Use container with correct metadata to node path * Remove libintl dependencies * Update dependencies from https://github.com/dotnet/runtime build 20210724.7 Microsoft.NETCore.App.Runtime.win-x64 , VS.Redist.Common.NetCore.SharedFramework.x64.6.0 From Version 6.0.0-preview.7.21361.10 -> To Version 6.0.0-rc.1.21374.7 * Disable testing against dumps on Alpine for now (until the 6.0 createdump change is in) Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com> Co-authored-by: Mike McLaughlin <[email protected]> Co-authored-by: Juan Hoyos <[email protected]> Co-authored-by: Juan Sebastian Hoyos Ayala <[email protected]> * Update dependencies from https://github.com/dotnet/runtime build 20210725.2 (#2449) [main] Update dependencies from dotnet/runtime * [main] Update dependencies from dotnet/aspnetcore (#2439) [main] Update dependencies from dotnet/aspnetcore * Update dependencies from https://github.com/dotnet/runtime build 20210726.24 (#2454) [main] Update dependencies from dotnet/runtime * Update dependencies from https://github.com/dotnet/aspnetcore build 20210727.2 (#2453) [main] Update dependencies from dotnet/aspnetcore * Revert "Update `ThreadCounts` usage based on a change (#2324)" (#2452) - Depends on dotnet/runtime#56346 - Reverted commit 3d57bee from PR #2324 since the relevant change to `ThreadCounts` was reverted in dotnet/runtime#56346 * Add thread adjustment reason for cooperative blocking (#2455) * Update dependencies from https://github.com/dotnet/runtime build 20210728.2 (#2457) [main] Update dependencies from dotnet/runtime * Update dependencies from https://github.com/dotnet/aspnetcore build 20210728.1 (#2456) [main] Update dependencies from dotnet/aspnetcore * Update alpine image that includes lldb python support and enable tests on 6.0 (#2460) * Update alpine image that includes lldb python support * Enable lldb and dump tests on Alpine * Don't run the bpmd portions of the tests on Alpine * Add requiresCapPtraceContainer:true to Alpine legs * We should check against alloc_allocated instead of heap_segment_allocated for ephemeral segment (#2450) * Update dependencies from https://github.com/dotnet/aspnetcore build 20210729.1 (#2461) [main] Update dependencies from dotnet/aspnetcore * Update dependencies from https://github.com/dotnet/runtime build 20210728.9 (#2462) [main] Update dependencies from dotnet/runtime * Remove old IVTs and add new one for dotnet-monitor. (#2463) * Fix unknown type/methods in core dumps. (#2442) Fixes some of the issues in #2375 The problem is that the image mapping memory service didn't convert the rva from a loaded layout calculated from the in-memory module to the file layout (the PEReader with the downloaded image). On Windows, images (native or managed) are always loaded layout so return false in IModule.IsFileLayout without calling GetPEInfo() to avoid the recursion that broken getting the info about coreclr.dll. It turns out that the heap dumps generated on Windows don't have the image in-memory. Don't get module version in GetPEInfo() to determine the layout. Cleanup. Skip relocations that span cache blocks. This happens very rarely and should not affect anything unless we get really really unlucky. * Update dependencies from https://github.com/dotnet/aspnetcore build 20210729.10 (#2464) [main] Update dependencies from dotnet/aspnetcore * Update dependencies from https://github.com/dotnet/runtime build 20210730.1 (#2465) [main] Update dependencies from dotnet/runtime * Update dependencies from https://github.com/dotnet/aspnetcore build 20210731.1 (#2467) [main] Update dependencies from dotnet/aspnetcore * Update dependencies from https://github.com/dotnet/runtime build 20210730.13 (#2468) [main] Update dependencies from dotnet/runtime * Update dependencies from https://github.com/dotnet/aspnetcore build 20210731.3 (#2469) [main] Update dependencies from dotnet/aspnetcore * Update dependencies from https://github.com/dotnet/runtime build 20210801.1 (#2470) [main] Update dependencies from dotnet/runtime * Update dependencies from https://github.com/dotnet/runtime build 20210801.3 (#2471) [main] Update dependencies from dotnet/runtime * Correcting grammar in "stopping the trace" output (#2458) * Update dependencies from https://github.com/dotnet/runtime build 20210802.10 (#2474) [main] Update dependencies from dotnet/runtime * Update dependencies from https://github.com/dotnet/runtime build 20210803.13 (#2475) [main] Update dependencies from dotnet/runtime * Update dependencies from https://github.com/dotnet/aspnetcore build 20210804.1 (#2479) [main] Update dependencies from dotnet/aspnetcore * Update dependencies from https://github.com/dotnet/aspnetcore build 20210804.17 (#2481) [main] Update dependencies from dotnet/aspnetcore * Update dependencies from https://github.com/dotnet/runtime build 20210805.1 (#2482) [main] Update dependencies from dotnet/runtime * Prevent queueing workitems in debuggee compilation on prebuild path (#2480) * dotnet-counters support for the new System.Diagnostics.Metrics APIs (#2373) * Refactoring and additional parse error handling The logic to create the EventPipeProvider list was intermingled with the parsing logic for the command line arguments. I eliminated the intermediate representation as List<string> _counterList and convert directly from command line args -> CounterFilter (renamed CounterSet). EventPipeProviders can now be computed directly from the CounterSet with no parsing mixed in. While refactoring the parsing code I also added more error handling for bad inputs, fixed incorrect descriptions of the format in the help text. * Support System.Diagnostics.Metrics Let dotnet-counters show metrics that were collected via our new System.Diagnostics.Metrics APIs. * Code review feedback * Update dependencies from https://github.com/dotnet/symstore build 20210802.1 (#2484) [main] Update dependencies from dotnet/symstore * Update dependencies from https://github.com/dotnet/runtime build 20210805.12 (#2488) [main] Update dependencies from dotnet/runtime * Update dependencies from https://github.com/dotnet/aspnetcore build 20210806.1 (#2487) [main] Update dependencies from dotnet/aspnetcore * Fix dotnet-counters console alignment (#2485) Text was oddly shifting one character to the right during updates. Fixed the off-by-one error in the update text positioning. * Update dependencies from https://github.com/dotnet/runtime build 20210806.5 (#2491) [main] Update dependencies from dotnet/runtime * Update dependencies from https://github.com/dotnet/aspnetcore build 20210806.20 (#2490) [main] Update dependencies from dotnet/aspnetcore * Update dependencies from https://github.com/dotnet/aspnetcore build 20210807.1 (#2492) [main] Update dependencies from dotnet/aspnetcore * Use absolute path for unix domain socket in listen mode (#2489) * Update dependencies from https://github.com/dotnet/aspnetcore build 20210808.1 (#2493) [main] Update dependencies from dotnet/aspnetcore * minor formatting fixes (#2494) * Update dependencies from https://github.com/dotnet/symstore build 20210809.1 (#2496) [main] Update dependencies from dotnet/symstore * Update dependencies from https://github.com/dotnet/aspnetcore build 20210810.1 (#2495) [main] Update dependencies from dotnet/aspnetcore * Update dependencies from https://github.com/dotnet/aspnetcore build 20210810.16 (#2497) [main] Update dependencies from dotnet/aspnetcore * [main] Update dependencies from dotnet/runtime (#2498) * Update dependencies from https://github.com/dotnet/runtime build 20210811.2 Microsoft.NETCore.App.Runtime.win-x64 , VS.Redist.Common.NetCore.SharedFramework.x64.6.0 From Version 6.0.0-rc.1.21406.5 -> To Version 6.0.0-rc.1.21411.2 * Fix SOS test failures with new runtime Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com> Co-authored-by: Mike McLaughlin <[email protected]> * Update dependencies from https://github.com/dotnet/runtime build 20210811.5 (#2500) [main] Update dependencies from dotnet/runtime * Update dependencies from https://github.com/dotnet/aspnetcore build 20210811.15 (#2499) [main] Update dependencies from dotnet/aspnetcore * Avoid checking for ephemeral heap segment in DumpGen (#2501) * Update dependencies from https://github.com/dotnet/aspnetcore build 20210812.9 (#2502) [main] Update dependencies from dotnet/aspnetcore * Update dependencies from https://github.com/dotnet/runtime build 20210813.5 (#2503) [main] Update dependencies from dotnet/runtime * Update dependencies from https://github.com/dotnet/aspnetcore build 20210813.12 (#2504) [main] Update dependencies from dotnet/aspnetcore * Update dependencies from https://github.com/dotnet/runtime build 20210814.1 (#2505) [main] Update dependencies from dotnet/runtime * Update dependencies from https://github.com/dotnet/runtime build 20210814.4 (#2506) [main] Update dependencies from dotnet/runtime * Update dependencies from https://github.com/dotnet/runtime build 20210815.6 (#2507) [main] Update dependencies from dotnet/runtime * Update dependencies from https://github.com/dotnet/aspnetcore build 20210817.1 (#2510) [main] Update dependencies from dotnet/aspnetcore * Update dependencies from https://github.com/dotnet/runtime build 20210817.1 (#2511) [main] Update dependencies from dotnet/runtime * Update dependencies from https://github.com/dotnet/aspnetcore build 20210817.14 (#2513) [main] Update dependencies from dotnet/aspnetcore * Update dependencies from https://github.com/dotnet/aspnetcore build 20210818.11 (#2516) [main] Update dependencies from dotnet/aspnetcore * Update dependencies from https://github.com/dotnet/aspnetcore build 20210819.24 (#2517) [main] Update dependencies from dotnet/aspnetcore * [main] Update dependencies from dotnet/runtime (#2514) [main] Update dependencies from dotnet/runtime * Update dependencies from https://github.com/dotnet/runtime build 20210820.29 (#2520) [main] Update dependencies from dotnet/runtime * Update dependencies from https://github.com/dotnet/aspnetcore build 20210820.26 (#2519) [main] Update dependencies from dotnet/aspnetcore * Update dependencies from https://github.com/dotnet/aspnetcore build 20210821.2 (#2521) [main] Update dependencies from dotnet/aspnetcore * Add new 'symbolicate' commands to dotnet-stack (#2436) * Initial trace event trigger implementation and tests. (#2508) * Initial trace event trigger implementation and tests. * Fix build problems with newer 6.0 SDKs/arcade (#2525) * Update dependencies from https://github.com/dotnet/installer build 20210418.6 Microsoft.Dotnet.Sdk.Internal From Version 6.0.100-preview.1.21103.13 -> To Version 6.0.100-preview.4.21218.6 * Update dependencies from https://github.com/dotnet/installer build 20210426.1 Microsoft.Dotnet.Sdk.Internal From Version 6.0.100-preview.1.21103.13 -> To Version 6.0.100-preview.5.21226.1 * Update dependencies from https://github.com/dotnet/installer build 20210502.3 Microsoft.Dotnet.Sdk.Internal From Version 6.0.100-preview.1.21103.13 -> To Version 6.0.100-preview.5.21252.3 * Update dependencies from https://github.com/dotnet/installer build 20210510.2 Microsoft.Dotnet.Sdk.Internal From Version 6.0.100-preview.1.21103.13 -> To Version 6.0.100-preview.5.21260.2 * Update dependencies from https://github.com/dotnet/installer build 20210516.3 Microsoft.Dotnet.Sdk.Internal From Version 6.0.100-preview.1.21103.13 -> To Version 6.0.100-preview.5.21266.3 * Update dependencies from https://github.com/dotnet/installer build 20210524.3 Microsoft.Dotnet.Sdk.Internal From Version 6.0.100-preview.1.21103.13 -> To Version 6.0.100-preview.6.21274.3 * Update dependencies from https://github.com/dotnet/installer build 20210530.2 Microsoft.Dotnet.Sdk.Internal From Version 6.0.100-preview.1.21103.13 -> To Version 6.0.100-preview.6.21280.2 * Update dependencies from https://github.com/dotnet/installer build 20210606.2 Microsoft.Dotnet.Sdk.Internal From Version 6.0.100-preview.1.21103.13 -> To Version 6.0.100-preview.6.21306.2 * Update dependencies from https://github.com/dotnet/installer build 20210613.2 Microsoft.Dotnet.Sdk.Internal From Version 6.0.100-preview.1.21103.13 -> To Version 6.0.100-preview.6.21313.2 * Update dependencies from https://github.com/dotnet/installer build 20210621.2 Microsoft.Dotnet.Sdk.Internal From Version 6.0.100-preview.1.21103.13 -> To Version 6.0.100-preview.7.21321.2 * Update dependencies from https://github.com/dotnet/installer build 20210627.2 Microsoft.Dotnet.Sdk.Internal From Version 6.0.100-preview.1.21103.13 -> To Version 6.0.100-preview.7.21327.2 * Update dependencies from https://github.com/dotnet/installer build 20210704.4 Microsoft.Dotnet.Sdk.Internal From Version 6.0.100-preview.1.21103.13 -> To Version 6.0.100-preview.7.21354.4 * Update dependencies from https://github.com/dotnet/installer build 20210710.1 Microsoft.Dotnet.Sdk.Internal From Version 6.0.100-preview.1.21103.13 -> To Version 6.0.100-preview.7.21360.1 * Update dependencies from https://github.com/dotnet/installer build 20210719.3 Microsoft.Dotnet.Sdk.Internal From Version 6.0.100-preview.1.21103.13 -> To Version 6.0.100-rc.1.21369.3 * Update dependencies from https://github.com/dotnet/installer build 20210726.3 Microsoft.Dotnet.Sdk.Internal From Version 6.0.100-preview.1.21103.13 -> To Version 6.0.100-rc.1.21376.3 * Update dependencies from https://github.com/dotnet/installer build 20210801.2 Microsoft.Dotnet.Sdk.Internal From Version 6.0.100-preview.1.21103.13 -> To Version 6.0.100-rc.1.21401.2 * Update dependencies from https://github.com/dotnet/installer build 20210808.2 Microsoft.Dotnet.Sdk.Internal From Version 6.0.100-preview.1.21103.13 -> To Version 6.0.100-rc.1.21408.2 * Update dependencies from https://github.com/dotnet/installer build 20210815.2 Microsoft.Dotnet.Sdk.Internal From Version 6.0.100-preview.1.21103.13 -> To Version 6.0.100-rc.1.21415.2 * Update dependencies from https://github.com/dotnet/installer build 20210823.2 Microsoft.Dotnet.Sdk.Internal From Version 6.0.100-preview.1.21103.13 -> To Version 6.0.100-rc.2.21423.2 * Update dependencies from https://github.com/dotnet/arcade build 20210514.2 Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.RemoteExecutor From Version 6.0.0-beta.21160.7 -> To Version 6.0.0-beta.21264.2 * Update dependencies from https://github.com/dotnet/arcade build 20210521.3 Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.RemoteExecutor From Version 6.0.0-beta.21160.7 -> To Version 6.0.0-beta.21271.3 * Update dependencies from https://github.com/dotnet/arcade build 20210528.1 Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.RemoteExecutor From Version 6.0.0-beta.21160.7 -> To Version 6.0.0-beta.21278.1 * Update dependencies from https://github.com/dotnet/arcade build 20210604.1 Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.RemoteExecutor From Version 6.0.0-beta.21160.7 -> To Version 6.0.0-beta.21304.1 * Update dependencies from https://github.com/dotnet/arcade build 20210611.3 Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.RemoteExecutor From Version 6.0.0-beta.21160.7 -> To Version 6.0.0-beta.21311.3 * Update dependencies from https://github.com/dotnet/arcade build 20210619.2 Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.RemoteExecutor From Version 6.0.0-beta.21160.7 -> To Version 6.0.0-beta.21319.2 * Update dependencies from https://github.com/dotnet/arcade build 20210624.3 Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.RemoteExecutor From Version 6.0.0-beta.21160.7 -> To Version 6.0.0-beta.21324.3 * Update dependencies from https://github.com/dotnet/arcade build 20210701.2 Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.RemoteExecutor From Version 6.0.0-beta.21160.7 -> To Version 6.0.0-beta.21351.2 * Update dependencies from https://github.com/dotnet/arcade build 20210707.3 Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.RemoteExecutor From Version 6.0.0-beta.21160.7 -> To Version 6.0.0-beta.21357.3 * Update dependencies from https://github.com/dotnet/arcade build 20210716.1 Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.RemoteExecutor From Version 6.0.0-beta.21160.7 -> To Version 6.0.0-beta.21366.1 * Update dependencies from https://github.com/dotnet/arcade build 20210723.11 Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.RemoteExecutor From Version 6.0.0-beta.21160.7 -> To Version 6.0.0-beta.21373.11 * Update dependencies from https://github.com/dotnet/arcade build 20210729.2 Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.RemoteExecutor From Version 6.0.0-beta.21160.7 -> To Version 6.0.0-beta.21379.2 * Update dependencies from https://github.com/dotnet/arcade build 20210806.6 Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.RemoteExecutor From Version 6.0.0-beta.21160.7 -> To Version 6.0.0-beta.21406.6 * Update dependencies from https://github.com/dotnet/arcade build 20210812.1 Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.RemoteExecutor From Version 6.0.0-beta.21160.7 -> To Version 6.0.0-beta.21412.1 * Update dependencies from https://github.com/dotnet/arcade build 20210820.4 Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.RemoteExecutor From Version 6.0.0-beta.21160.7 -> To Version 6.0.0-beta.21420.4 * Fix build problems with newer 6.0 SDKs/arcade Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com> * Update dependencies from https://github.com/dotnet/aspnetcore build 20210825.1 (#2524) Microsoft.AspNetCore.App.Ref.Internal , Microsoft.AspNetCore.App.Ref From Version 6.0.0-rc.2.21421.2 -> To Version 6.0.0-rc.2.21425.1 Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com> * [main] Update dependencies from dotnet/runtime (#2523) * Update dependencies from https://github.com/dotnet/runtime build 20210823.19 Microsoft.NETCore.App.Runtime.win-x64 , VS.Redist.Common.NetCore.SharedFramework.x64.6.0 From Version 6.0.0-rc.2.21420.29 -> To Version 6.0.0-rc.2.21423.19 * Update dependencies from https://github.com/dotnet/runtime build 20210824.25 Microsoft.NETCore.App.Runtime.win-x64 , VS.Redist.Common.NetCore.SharedFramework.x64.6.0 From Version 6.0.0-rc.2.21420.29 -> To Version 6.0.0-rc.2.21424.25 Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com> * Update dependencies from https://github.com/dotnet/symstore build 20210823.1 (#2522) Microsoft.SymbolStore From Version 1.0.240901 -> To Version 1.0.242301 Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com> * Update dependencies from https://github.com/dotnet/aspnetcore build 20210826.1 (#2526) [main] Update dependencies from dotnet/aspnetcore * Update dependencies from https://github.com/dotnet/runtime build 20210825.6 (#2527) [main] Update dependencies from dotnet/runtime * Update dependencies from https://github.com/microsoft/clrmd build 20210826.6 (#2530) [main] Update dependencies from microsoft/clrmd * Fix minor spelling error in dotnet-dsrouter warning message. (#2528) * Update dependencies from https://github.com/dotnet/aspnetcore build 20210827.1 (#2529) [main] Update dependencies from dotnet/aspnetcore * Update dependencies from https://github.com/dotnet/symstore build 20210826.1 (#2531) [main] Update dependencies from dotnet/symstore * Update dependencies from https://github.com/dotnet/runtime build 20210827.2 (#2532) [main] Update dependencies from dotnet/runtime * Update dependencies from https://github.com/dotnet/runtime build 20210828.1 (#2534) [main] Update dependencies from dotnet/runtime * Update dependencies from https://github.com/dotnet/aspnetcore build 20210828.1 (#2533) [main] Update dependencies from dotnet/aspnetcore * Update dependencies from https://github.com/dotnet/aspnetcore build 20210828.15 (#2535) [main] Update dependencies from dotnet/aspnetcore * Update dependencies from https://github.com/dotnet/arcade build 20210827.6 (#2537) [main] Update dependencies from dotnet/arcade * Update dependencies from https://github.com/dotnet/installer build 20210830.3 (#2540) [main] Update dependencies from dotnet/installer * Update dependencies from https://github.com/dotnet/runtime build 20210829.8 (#2539) [main] Update dependencies from dotnet/runtime * Update dependencies from https://github.com/dotnet/aspnetcore build 20210830.3 (#2538) [main] Update dependencies from dotnet/aspnetcore * Update dependencies from https://github.com/dotnet/installer build 20210830.28 (#2543) [main] Update dependencies from dotnet/installer * Refactor IPC communication to allow for async and cancellation. (#2350) * Refactor IPC communication to allow for async and cancellation. Refactor tests to flex both non-async and async methods. * Update dependencies from https://github.com/dotnet/symstore build 20210830.1 (#2545) [main] Update dependencies from dotnet/symstore * Update dependencies from https://github.com/dotnet/runtime build 20210830.24 (#2546) [main] Update dependencies from dotnet/runtime * [main] Update dependencies from dotnet/aspnetcore (#2544) [main] Update dependencies from dotnet/aspnetcore * Update dependencies from https://github.com/dotnet/runtime build 20210831.13 (#2548) [main] Update dependencies from dotnet/runtime * Update dependencies from https://github.com/dotnet/aspnetcore build 20210902.1 (#2549) [main] Update dependencies from dotnet/aspnetcore * Update dependencies from https://github.com/dotnet/runtime build 20210902.2 (#2551) [main] Update dependencies from dotnet/runtime * Remove blob feed (#2553) * Update dependencies from https://github.com/microsoft/clrmd build 20210831.1 (#2547) Microsoft.Diagnostics.Runtime , Microsoft.Diagnostics.Runtime.Utilities From Version 2.0.242606 -> To Version 2.0.243101 Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com> * Update dependencies from https://github.com/dotnet/symstore build 20210901.1 (#2550) Microsoft.SymbolStore From Version 1.0.243001 -> To Version 1.0.245101 Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com> * Update dependencies from https://github.com/dotnet/runtime build 20210902.24 (#2556) [main] Update dependencies from dotnet/runtime * Update dependencies from https://github.com/dotnet/aspnetcore build 20210903.2 (#2555) Microsoft.AspNetCore.App.Ref.Internal , Microsoft.AspNetCore.App.Ref From Version 6.0.0-rc.2.21452.1 -> To Version 6.0.0-rc.2.21453.2 Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com> * Update dependencies from https://github.com/dotnet/runtime build 20210904.1 (#2560) Microsoft.NETCore.App.Runtime.win-x64 , VS.Redist.Common.NetCore.SharedFramework.x64.6.0 From Version 6.0.0-rc.2.21452.24 -> To Version 6.0.0-rc.2.21454.1 Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com> * Update dependencies from https://github.com/dotnet/installer build 20210906.2 (#2562) Microsoft.Dotnet.Sdk.Internal From Version 6.0.100-rc.2.21430.28 -> To Version 6.0.100-rc.2.21456.2 Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com> * [main] Update dependencies from dotnet/aspnetcore (#2559) * Update dependencies from https://github.com/dotnet/aspnetcore build 20210903.33 Microsoft.AspNetCore.App.Ref.Internal , Microsoft.AspNetCore.App.Ref From Version 6.0.0-rc.2.21453.2 -> To Version 6.0.0-rc.2.21453.33 * Update dependencies from https://github.com/dotnet/aspnetcore build 20210905.6 Microsoft.AspNetCore.App.Ref.Internal , Microsoft.AspNetCore.App.Ref From Version 6.0.0-rc.2.21453.2 -> To Version 6.0.0-rc.2.21455.6 Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com> * [main] Update dependencies from dotnet/arcade (#2561) [main] Update dependencies from dotnet/arcade - Change netcoreapp2.1 to netcoreapp3.1 and stop testing against 2.1 - Don't host the managed SOS code on 2.1 anymore * In dotnet-trace/counters disposed of the server when we received ctrl+C while waiting for clients to connect. closes #2426 (#2476) * Disposed of the server when we received ctrl+C while waiting for clients to connect * removed deletion of files to alow the server to clean things up * Disabling EventLogsPipeUnitTests.TestLogsWildcardCategory and EventCounterTriggerTests.EventCounterTriggerWithEventPipePipelineTest (#2569) * Disabling EventLogsPipeUnitTests.TestLogsWildcardCategory and EventCounterTriggerTests.EventCounterTriggerWithEventPipePipelineTest They are constantly failing. * Only skip on Windows * Disabled EventLogsPipelineUnitTests.TestLogsAllCategoriesAllLevels for Windows also * Disable an unreliable SOS test on MacOS (#1950) * Update dependencies from https://github.com/dotnet/symstore build 20210907.1 (#2566) Microsoft.SymbolStore From Version 1.0.245101 -> To Version 1.0.245701 Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com> * Update dependencies from https://github.com/dotnet/aspnetcore build 20210908.2 (#2565) Microsoft.AspNetCore.App.Ref.Internal , Microsoft.AspNetCore.App.Ref From Version 6.0.0-rc.2.21455.6 -> To Version 6.0.0-rc.2.21458.2 Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com> * Update dependencies from https://github.com/dotnet/runtime build 20210908.2 (#2567) Microsoft.NETCore.App.Runtime.win-x64 , VS.Redist.Common.NetCore.SharedFramework.x64.6.0 From Version 6.0.0-rc.2.21454.1 -> To Version 6.0.0-rc.2.21458.2 Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com> * Fix default IPC port for IPC server, TCP client mode. (#2557) * Update dependencies from https://github.com/dotnet/aspnetcore build 20210908.47 (#2570) [main] Update dependencies from dotnet/aspnetcore * Update dependencies from https://github.com/dotnet/symstore build 20210908.1 (#2571) [main] Update dependencies from dotnet/symstore * Update dependencies from https://github.com/dotnet/runtime build 20210908.16 (#2572) [main] Update dependencies from dotnet/runtime * Enable crash dump report generation in SOS tests (#2558) Enable crash dump report generation in SOS tests Load crash report json file and check some common values. Enable Windows triage and heap dump testing Check for ctrl-c on console writelines Fix arm32/x86 sign extensions problems in C++ data targets Fix dotnet-dump collect dump type and the exception display in commands Fix eeversion command when private build version like 42.42.42.42424 Add the directory of the dump to the symbol search path Remove "ChangeEngineState" message on every stop in windbg. Fix module relocations fixes. It was using the wrong rva. Needed the original rva not the translated file layout one. Better SOS module load failure message. Remove System.Memory dependencies * Update dependencies from https://github.com/dotnet/runtime build 20210909.18 (#2575) [main] Update dependencies from dotnet/runtime * Update dependencies from https://github.com/dotnet/aspnetcore build 20210910.4 (#2574) [main] Update dependencies from dotnet/aspnetcore * Enable ProcessInfo2 in DiagnosticsClient. (#2564) Update tests to reflect when entrypoint is available. * Update dependencies from https://github.com/dotnet/runtime build 20210910.14 (#2579) [main] Update dependencies from dotnet/runtime * Update dependencies from https://github.com/dotnet/aspnetcore build 20210911.3 (#2578) [main] Update dependencies from dotnet/aspnetcore * Fix reverse named pipe server resume hang. (#2573) Running a reverse connect (--diagnostic-port) against a runtime running with nosuspend, hangs/deadlocks IPC client and IPC server thread on start collect -> resume command sequence. Happens since IPC server thread will write out initial header data into stream but client only waits for session id and will then issue a resume command. If the reverse server is not setup with any buffering this will cause IPC server thread to block when writing into session, server thread won’t be able to handle incoming resume command, and client won’t read anything from session unblocking server thread, since its waiting on completion of resume command. This is not an issue on Unix domain, TCP/IP sockets since it by default will allocate smaller in/out buffers, preventing server to block. It’s not an issue on runtime IPC named pipe listener port’s, since they are allocated with 16 KB in/out buffers. It is however an issue on reverse servers created by IpcWindowsNamedPipeServerTransport since those will default to 0 byte in/out buffers, triggering the issue. Fix increase the default size of in/out buffers in sync with default named pipe in/out buffers used by runtime, 16KB. Not an issue on CI since CI uses its own implementation of reverse named pipe server, using 16 KB as in/out buffers as well. Keeping Unix Domain, TCP/IP sockets as is, since runtime also uses defaults in its implementation. CI on the other hand uses 16 KB for Unix Domain Socket in/out buffers, something IpcTcpSocketServerTransport could do as well, but could be adjusted if ever needed. The number of bytes written into stream when starting up streaming is small (xxx) and should fit into the default buffer sizes used by Unix Domain, TCP/IP sockets. This fix is however just fixing the symptom of the underlying issue, that the IPC server thread writes into a stream that it expects reader to consume or it might block from processing further of commands. One alternative runtime fix would be to move the write of stream init data into streaming thread, but since we also write all rundown data on IPC server thread it won’t solve the complete problem since stop collect command could cause same issues. If client doesn’t have a consumer reading the data on the stopped stream, while client is stopping it in parallel, it will block. This is much worse scenario since the size of the data written back as part of rundown will most likely be bigger than any IPC buffer sizes. Changing this behaviour in runtime requires some re-architecture of current IPC infrastructure moving write into trace session away from server thread. * Update dependencies from https://github.com/dotnet/aspnetcore build 20210911.23 (#2580) [main] Update dependencies from dotnet/aspnetcore * Update dependencies from https://github.com/dotnet/runtime build 20210911.1 (#2581) [main] Update dependencies from dotnet/runtime * Update dependencies from https://github.com/dotnet/arcade build 20210909.5 (#2582) [main] Update dependencies from dotnet/arcade * Update dependencies from https://github.com/dotnet/aspnetcore build 20210912.1 (#2583) [main] Update dependencies from dotnet/aspnetcore * Update dependencies from https://github.com/dotnet/installer build 20210910.37 (#2584) [main] Update dependencies from dotnet/installer * altered dotnet-counters to work with inputRedirection #2329 (#2466) * altered dotnet-counters to work with inputRedirection #2329 * Altered to allow for multiple key presses and removed debugging code * Altered to allow for multiple key presses * Update dependencies from https://github.com/dotnet/runtime build 20210913.21 (#2587) [main] Update dependencies from dotnet/runtime * Update dependencies from https://github.com/dotnet/symstore build 20210913.1 (#2586) [main] Update dependencies from dotnet/symstore * Update dependencies from https://github.com/dotnet/aspnetcore build 20210913.5 (#2585) Microsoft.AspNetCore.App.Ref.Internal , Microsoft.AspNetCore.App.Ref From Version 6.0.0-rc.2.21462.1 -> To Version 6.0.0-rc.2.21463.5 Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com> * Update dependencies from https://github.com/dotnet/aspnetcore build 20210915.1 (#2588) [main] Update dependencies from dotnet/aspnetcore * Update dependencies from https://github.com/dotnet/runtime build 20210914.21 (#2589) [main] Update dependencies from dotnet/runtime * Update dependencies from https://github.com/dotnet/symstore build 20210915.1 (#2594) [main] Update dependencies from dotnet/symstore * Update dependencies from https://github.com/dotnet/aspnetcore build 20210915.22 (#2593) [main] Update dependencies from dotnet/aspnetcore * Update dependencies from https://github.com/dotnet/aspnetcore build 20210916.24 (#2597) [main] Update dependencies from dotnet/aspnetcore * Update dependencies from https://github.com/dotnet/installer build 20210916.6 (#2602) [main] Update dependencies from dotnet/installer * Update dependencies from https://github.com/dotnet/arcade build 20210916.4 (#2601) [main] Update dependencies from dotnet/arcade * Asp.net triggers (#2592) * Asp.net triggers * PR Feedback * StatusCodeRange PR Feedback * Additional PR feedback * PR feedback * Fix misc SOS bugs (#2600) Fix misc SOS bugs * Fix bug in the AddFilesFromDirectoryToTpaList issue: #2596 * Added some logging to GetLineByOffset * Improve SymbolService.ParseSymbolPath support for Watson. Issue #2512. Can now handle the various symbol paths that Watson can throw at us. Doesn't support actually calling the symbol server dll like in the symsrv*symaudit.dll*\\server\share syntax. The dll is ignored. * Minor doc updates * Better loadsymbols error message when no server is set * Update dependencies from https://github.com/dotnet/aspnetcore build 20210917.1 (#2599) [main] Update dependencies from dotnet/aspnetcore * Update dependencies from https://github.com/dotnet/symstore build 20210920.1 (#2605) [main] Update dependencies from dotnet/symstore * Update dependencies from https://github.com/dotnet/aspnetcore build 20210921.8 (#2604) [main] Update dependencies from dotnet/aspnetcore * [main] Update dependencies from dotnet/runtime (#2606) * Update dependencies from https://github.com/dotnet/runtime build 20210920.22 Microsoft.NETCore.App.Runtime.win-x64 , VS.Redist.Common.NetCore.SharedFramework.x64.6.0 From Version 6.0.0-rc.2.21464.21 -> To Version 6.0.0-rtm.21470.22 * Fix SOS bpmd tests on 6.0 runtime Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com> Co-authored-by: Mike McLaughlin <[email protected]> * Update dependencies from https://github.com/dotnet/aspnetcore build 20210921.45 (#2609) [main] Update dependencies from dotnet/aspnetcore * Update dependencies from https://github.com/dotnet/runtime build 20210921.19 (#2610) [main] Update dependencies from dotnet/runtime * Validate ProcessInfo is same (except entrypoint) before and after resume. (#2603) * Update dependencies from https://github.com/dotnet/aspnetcore build 20210923.1 (#2612) [main] Update dependencies from dotnet/aspnetcore * Update dependencies from https://github.com/dotnet/runtime build 20210922.13 (#2613) [main] Update dependencies from dotnet/runtime * Update dependencies from https://github.com/dotnet/aspnetcore build 20210924.1 (#2614) [main] Update dependencies from dotnet/aspnetcore * Update dependencies from https://github.com/dotnet/aspnetcore build 20210924.41 (#2616) [main] Update dependencies from dotnet/aspnetcore * Disabling TestLogsAllCategoriesDefaultLevel on windows due to intermittent failures (#2617) * Update dependencies from https://github.com/dotnet/aspnetcore build 20210925.9 (#2618) [main] Update dependencies from dotnet/aspnetcore * Update dependencies from https://github.com/dotnet/arcade build 20210924.2 (#2619) [main] Update dependencies from dotnet/arcade * Update dependencies from https://github.com/dotnet/installer build 20210926.2 (#2620) [main] Update dependencies from dotnet/installer * Add Guid Serialization to support new SetStartupProfiler method (#2621) * Update dependencies from https://github.com/dotnet/aspnetcore build 20210927.30 (#2622) [main] Update dependencies from dotnet/aspnetcore * Update dependencies from https://github.com/dotnet/symstore build 20210927.1 (#2623) [main] Update dependencies from dotnet/symstore * Update dependencies from https://github.com/dotnet/runtime build 20210927.8 (#2624) [main] Update dependencies from dotnet/runtime * Update dependencies from https://github.com/dotnet/aspnetcore build 20210929.1 (#2626) [main] Update dependencies from dotnet/aspnetcore * Update dependencies from https://github.com/dotnet/runtime build 20210928.11 (#2627) [main] Update dependencies from dotnet/runtime * Add glob support for asp.net triggers (#2615) * Add glob support for asp.net triggers * PR feedback * Pr feedback Co-authored-by: mikelle-rogers <[email protected]> Co-authored-by: Mikelle Rogers <[email protected]> Co-authored-by: dotnet-maestro[bot] <42748379+dotnet-maestro[bot]@users.noreply.github.com> Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com> Co-authored-by: Mike McLaughlin <[email protected]> Co-authored-by: Koundinya Veluri <[email protected]> Co-authored-by: Andrew Au <[email protected]> Co-authored-by: Justin Anderson <[email protected]> Co-authored-by: Matt Thalman <[email protected]> Co-authored-by: Noah Falk <[email protected]> Co-authored-by: Filip Navara <[email protected]> Co-authored-by: John Zabroski <[email protected]> Co-authored-by: JongHeonChoi <[email protected]> Co-authored-by: Johan Lorensson <[email protected]> Co-authored-by: Matt Mitchell <[email protected]> Co-authored-by: Wiktor Kopec <[email protected]> Co-authored-by: Tom McDonald <[email protected]> Co-authored-by: Patrick Fenelon <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an incomplete fix for #2451.
The extra check if the segment is
ephemeral_heap_segmentis bogus. CLRMD would guarantee the generation range have length 0 anyway.https://github.com/microsoft/clrmd/blob/124b189a2519c4f13610c6bf94e516243647af2e/src/Microsoft.Diagnostics.Runtime/src/Builders/SegmentBuilder.cs#L47-L49
With this change, together with microsoft/clrmd#945, I have got the unit test working locally for
USE_REGIONS.