Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The DumpGen SOS unit test is failed under USE_REGIONS #2451

Closed
cshung opened this issue Jul 27, 2021 · 4 comments
Closed

The DumpGen SOS unit test is failed under USE_REGIONS #2451

cshung opened this issue Jul 27, 2021 · 4 comments
Assignees
Labels
bug Something isn't working sos
Milestone

Comments

@cshung
Copy link
Member

cshung commented Jul 27, 2021

It looks like a possible cause is that we haven't implement microsoft/clrmd#936 yet.

@cshung cshung added the bug Something isn't working label Jul 27, 2021
@mikem8361
Copy link
Member

Is there any way you could fix this?

@cshung
Copy link
Member Author

cshung commented Aug 12, 2021

In order to fix this bug, we need to

  1. Get the DAC to expose the data so that we can properly walk the heap under USE_REGIONS . Fix DacHeapWalker for USE_REGIONS runtime#56796 should fix it.

  2. Get CLRMD to expose the data so that DumpGen can access it. Support regions microsoft/clrmd#945 should fix it.

  3. Get a new version of CLRMD published, and

  4. Get this repo to depends on the new version.

None of these is very difficult, I could fix them, but it will probably take some time before we can complete them all.

@mikem8361
Copy link
Member

Other than your current runtime PR (which hopefully can get merged before Tuesday) all of this sounds like out of band work in clrmd/diagnostics. I was hoping you could eventually do this work when you have time because the diagnostic team is a little overbooked and under staffed. If you can do this work (Lee can probably help with the clrmd work), please assign this issue to yourself.

@cshung
Copy link
Member Author

cshung commented Oct 5, 2021

I verified that #2547 fixed the issue, the test is now passing for USE_REGIONS.

@cshung cshung closed this as completed Oct 5, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Jun 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working sos
Projects
None yet
Development

No branches or pull requests

3 participants