This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
Upgrade CoreFX to buildtools 106 #3966
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Consumes some changes to perf testing from dotnet/buildtools#308
|
It looks like buildtools is already at 107... should we be going to that? Though it's not clear if there are any actual changes between 106 and 107. |
|
Assuming we do want 106, LGTM |
|
It doesn't look like there's any changes between 106 and 107. The official build must have gotten kicked off twice for some reason. LGTM. |
|
Looks like the version is already bumped to 00107 via 0931c34 (landed on master). 😄 |
|
Works for me, thanks @jasonwilliams200OK :) I need to push another buildtools fix, so expect another of these PRs in a little while. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Consumes some changes to perf testing from dotnet/buildtools#308
@stephentoub @mellinoe