This repository has been archived by the owner on Jan 11, 2024. It is now read-only.
Updated perf testing targets #308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -61,6 +63,11 @@ | |||
| <AssemblyInfoLines Condition="'$(SkipFrameworkAssemblyMetadata)' != 'true'" | |||
| Include="[assembly:System.Reflection.AssemblyMetadata("%(AssemblyMetadata.Identity)", "%(AssemblyMetadata.Value)")]" /> | |||
| </ItemGroup> | |||
|
|
|||
| <ItemGroup Condition="'$(RunPerfTestsForProject)' == 'true' and '$(DisableTests)' != 'true'"> | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
I've renamed Targets=>PackageFiles yesterday so you will need to sync master to resolve your conflicts. |
Update to the latest xunit-performance package. Also added a target that will add the new OptimizeForBenchmarks assembly tag to any perf test build. This tag was added in microsoft/xunit-performance#94
|
@weshaggard done and done |
|
LGTM. Note you will also need to update test-runtime\project.json in CoreFX repo as well. |
rainersigwald
pushed a commit
to rainersigwald/buildtools
that referenced
this pull request
Apr 25, 2018
Update WindowsAzure.Storage to latest (dotnet#307)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update to the latest xunit-performance package. Also added a target that will add the new OptimizeForBenchmarks assembly tag to any perf test build. This tag was added in microsoft/xunit-performance#94