Skip to content
This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
/ corefx Public archive

Clear plaintext when AesCcm authentication fails #38899

Merged
merged 2 commits into from
Jun 26, 2019
Merged

Clear plaintext when AesCcm authentication fails #38899

merged 2 commits into from
Jun 26, 2019

Conversation

krwq
Copy link
Member

@krwq krwq commented Jun 25, 2019

Fixes: https://github.com/dotnet/corefx/issues/32710

Seems whatever version of OpenSsl ships on Arm64 it does not clear plaintext when authentication fails.

Adding it on all platforms - since it's a failing path the perf is irrelevant

@krwq
Copy link
Member Author

krwq commented Jun 25, 2019

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 4 pipeline(s).

@krwq
Copy link
Member Author

krwq commented Jun 25, 2019

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 4 pipeline(s).

@krwq krwq changed the title [Testing] Re-enable disabled AesCcm test cases Clear plaintext when AesCcm authentication fails Jun 26, 2019
@krwq krwq requested a review from bartonjs June 26, 2019 04:48
@krwq krwq marked this pull request as ready for review June 26, 2019 04:48
@krwq
Copy link
Member Author

krwq commented Jun 26, 2019

Sanity started manual run just in case since the CI skipped running tests on arm64 on this iteration:
https://dev.azure.com/dnceng/public/_build/results?buildId=239397

@bartonjs
Copy link
Member

Debian.9.Arm32.Open-arm:

===========================================================================================================
/root/helix/work/workitem /root/helix/work/workitem
  Discovering: System.Data.Common.Tests (method display = ClassAndMethod, method display options = None)
  Discovered:  System.Data.Common.Tests (found 1785 of 1787 test cases)
  Starting:    System.Data.Common.Tests (parallel test collections = on, max threads = 4)
./RunTests.sh: line 164:    16 Aborted                 (core dumped) "$RUNTIME_PATH/dotnet" xunit.console.dll System.Data.Common.Tests.dll -xml testResults.xml -nologo -nocolor -notrait category=nonnetcoreapptests -notrait category=nonlinuxtests -notrait category=IgnoreForCI -notrait category=OuterLoop -notrait category=failing $RSP_FILE
/root/helix/work/workitem
----- end Wed Jun 26 11:44:26 UTC 2019 ----- exit code 134 ----------------------------------------------------------
exit code 134 means SIGABRT Abort. Managed or native assert, or runtime check such as heap corruption, caused call to abort(). Core dumped.
Looking around for any Linux dump...
... found no dump in /root/helix/work/workitem

Debian.9.Arm32.Open-arm:

===========================================================================================================
/root/helix/work/workitem /root/helix/work/workitem
  Discovering: System.Runtime.Tests (method display = ClassAndMethod, method display options = None)
  Discovered:  System.Runtime.Tests (found 5327 of 5368 test cases)
  Starting:    System.Runtime.Tests (parallel test collections = on, max threads = 4)
./RunTests.sh: line 164:    16 Aborted                 (core dumped) "$RUNTIME_PATH/dotnet" xunit.console.dll System.Runtime.Tests.dll -xml testResults.xml -nologo -nocolor -notrait category=nonnetcoreapptests -notrait category=nonlinuxtests -notrait category=IgnoreForCI -notrait category=OuterLoop -notrait category=failing $RSP_FILE
/root/helix/work/workitem
----- end Wed Jun 26 11:47:49 UTC 2019 ----- exit code 134 ----------------------------------------------------------
exit code 134 means SIGABRT Abort. Managed or native assert, or runtime check such as heap corruption, caused call to abort(). Core dumped.

And it also hit #38444.

None of these really seem related to this change; and all of the System.Security.Cryptography tests passed on all configs. So it seems mergable.

@krwq krwq merged commit b958f70 into master Jun 26, 2019
@jkotas jkotas deleted the krwq-patch-2 branch June 29, 2019 02:10
@karelz karelz added this to the 3.0 milestone Jul 16, 2019
picenka21 pushed a commit to picenka21/runtime that referenced this pull request Feb 18, 2022
* Re-enable disabled AesCcm test cases

* Clear plaintext on failure


Commit migrated from dotnet/corefx@b958f70
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ARM64] Multiple test failures : /System.Security.Cryptography.Algorithms/tests/AesCcmTests.cs
3 participants