This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 4.9k
Clear plaintext when AesCcm authentication fails #38899
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
/azp run |
Azure Pipelines successfully started running 4 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 4 pipeline(s). |
krwq
changed the title
[Testing] Re-enable disabled AesCcm test cases
Clear plaintext when AesCcm authentication fails
Jun 26, 2019
bartonjs
approved these changes
Jun 26, 2019
Sanity started manual run just in case since the CI skipped running tests on arm64 on this iteration: |
Debian.9.Arm32.Open-arm:
Debian.9.Arm32.Open-arm:
And it also hit #38444. None of these really seem related to this change; and all of the System.Security.Cryptography tests passed on all configs. So it seems mergable. |
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
* Re-enable disabled AesCcm test cases * Clear plaintext on failure Commit migrated from dotnet/corefx@b958f70
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: https://github.com/dotnet/corefx/issues/32710
Seems whatever version of OpenSsl ships on Arm64 it does not clear plaintext when authentication fails.
Adding it on all platforms - since it's a failing path the perf is irrelevant