Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ARM64] Multiple test failures : /System.Security.Cryptography.Algorithms/tests/AesCcmTests.cs #27579

Closed
dmklementiev-zz opened this issue Oct 9, 2018 · 5 comments · Fixed by dotnet/corefx#38899
Assignees
Milestone

Comments

@dmklementiev-zz
Copy link
Contributor

Note that the failure occurs on Arm64 only!

The test: https://github.com/dmklementiev/corefx/blob/master/src/System.Security.Cryptography.Algorithms/tests/AesCcmTests.cs has failed 37 times (details here https://mc.dot.net/#/user/dmklementiev/pr~2Fjenkins~2Fdotnet~2Fcorefx~2Fmaster~2F/test~2Ffunctional~2Fcli~2F/f8e7a02f30f1062cd70104bbf1a364e8acedb3bd/workItem/System.Security.Cryptography.Algorithms.Tests) with the following details:

Unhandled Exception of Type Xunit.Sdk.EqualException
Message :
Assert.Equal() Failure
Expected: Byte[] [0, 0, 0, 0, 0, ...]
Actual: Byte[] [163, 189, 216, 244, 17, ...]
Stack Trace :
at System.Security.Cryptography.Algorithms.Tests.AesCcmTests.AesCcmNistTestsTamperCiphertext(AEADTest testCase) in /mnt/j/workspace/dotnet_corefx/master/linux-TGroup_netcoreapp+CGroup_Release+AGroup_arm64+TestOuter_false_prtest/src/System.Security.Cryptography.Algorithms/tests/AesCcmTests.cs:line 381

Similar failures happened for the same StackTrace for different Actual: Byte[] values. Just a few for example:
Actual: Byte[] [43, 61, 80, 100, 121, ...]
Actual: Byte[] [221, 239, 2, 22, 43, ...]
Actual: Byte[] [213, 231, 250, 14, 35, ...]

The same at Stack Trace:

at System.Security.Cryptography.Algorithms.Tests.AesCcmTests.AesCcmNistTestsTamperTag(AEADTest testCase) in /mnt/j/workspace/dotnet_corefx/master/linux-TGroup_netcoreapp+CGroup_Release+AGroup_arm64+TestOuter_false_prtest/src/System.Security.Cryptography.Algorithms/tests/AesCcmTests.cs:line 359

The same at Stack Trace:

at System.Security.Cryptography.Algorithms.Tests.AesCcmTests.InplaceEncryptTamperTagDecrypt() in /mnt/j/workspace/dotnet_corefx/master/linux-TGroup_netcoreapp+CGroup_Release+AGroup_arm64+TestOuter_false_prtest/src/System.Security.Cryptography.Algorithms/tests/AesCcmTests.cs:line 319

@vcsjones
Copy link
Member

vcsjones commented Oct 9, 2018

cc @krwq

@dmklementiev-zz
Copy link
Contributor Author

dmklementiev-zz commented Oct 9, 2018

I am going to disable the corresponding tests this morning before this is enabled in regular CI. Created this issues to add [ActiveIssue(32710, TestPlatforms.AnyUnix)] to the corresponding tests before committing.

@krwq
Copy link
Member

krwq commented Oct 9, 2018

@dmklementiev do we have any way to disable these tests on ARM only?

@krwq krwq changed the title Multiple test failures : /System.Security.Cryptography.Algorithms/tests/AesCcmTests.cs [ARM64] Multiple test failures : /System.Security.Cryptography.Algorithms/tests/AesCcmTests.cs Oct 9, 2018
@dmklementiev-zz
Copy link
Contributor Author

I would love to, but it doesn't seem you have this kind of granularity - look at how TestPlatforms are defined:

https://github.com/dotnet/buildtools/blob/2f0dec8eba53942a758910ea7b4cc79e4a7d2c36/src/xunit.netcore.extensions/TestPlatforms.cs#L10-L19

I was also told by Wes that picking Arm64 only is not possible today. Please let me know if I am missing something, so I will gladly change it to be more granular - for Arm64 only.

@weshaggard
Copy link
Member

test disabled with dotnet/corefx#32566

@dmklementiev do we have any way to disable these tests on ARM only?

Currently there isn't a way but there is a PR someone started but never got finished dotnet/buildtools#1659

@msftgits msftgits transferred this issue from dotnet/corefx Jan 31, 2020
@msftgits msftgits added this to the 3.0 milestone Jan 31, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Dec 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants