This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
Support building corefx in VS2019 #35197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
safern
force-pushed
the
Vs2019NativeBuild
branch
from
b7f1d72 to
26ca6b9
Compare
danmoseley
approved these changes
Feb 9, 2019
ahsonkhan
reviewed
Feb 9, 2019
ahsonkhan
reviewed
Feb 9, 2019
safern
force-pushed
the
Vs2019NativeBuild
branch
from
26ca6b9 to
4bfd00f
Compare
ViktorHofer
approved these changes
Feb 9, 2019
|
Did you test if that requires the v142 toolset to be installed as an additional component? If yes, we should add it to the list of required individual components in a non workload based install. |
|
Yes it requires v142 to be installed good point. It will be installed by default when installing the v141 toolset though. I think they made them Inclusive. |
|
v140 is also still listed. Is it required? |
|
Thanks, @safern! |
stephentoub
approved these changes
Feb 9, 2019
tannergooding
approved these changes
Feb 11, 2019
safern
force-pushed
the
Vs2019NativeBuild
branch
from
4bfd00f to
7a51ea6
Compare
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
* Support building corefx in VS2019 * PR Feedback and update docs for VS2019 Commit migrated from dotnet/corefx@fd736ea
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: https://github.com/dotnet/corefx/issues/34613
Fixes: https://github.com/dotnet/corefx/issues/34413
CMake 3.14.0-rc1 is now out the door and can be downloaded from: https://cmake.org/download/
This version now supports the new toolset version which is
142and now contains a VS2019 project generator. Note that since in VS2019 Preview1 the toolset version was still141it is required to have VS2019 Preview2 for it to work correctly.cc: @stephentoub @ViktorHofer @danmosemsft @ahsonkhan @ericstj