Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Once CMake supports VS2019 as the project generator use it if installed #28334

Closed
safern opened this issue Jan 7, 2019 · 2 comments
Closed
Assignees
Labels
area-Infrastructure-libraries enhancement Product code improvement that does NOT require public API changes/additions
Milestone

Comments

@safern
Copy link
Member

safern commented Jan 7, 2019

In: dotnet/corefx#34381 we enabled building and generating the native project with VS2019, but CMake doesn't support VS2019 as the project generator. So we reverted the generator change in: dotnet/corefx#34412

This issue is to track CMake's support for VS2019 and to update the generator script.

cc: @ViktorHofer

@safern safern self-assigned this Jan 7, 2019
@safern
Copy link
Member Author

safern commented Jan 7, 2019

There is already a PR in cmake to add the 2019 generator: https://gitlab.kitware.com/cmake/cmake/merge_requests/2711

@safern
Copy link
Member Author

safern commented Jan 16, 2019

PR was replaced with: https://gitlab.kitware.com/cmake/cmake/merge_requests/2789

It was merged 2 days ago and it is marked for 3.14 cmake version.

@msftgits msftgits transferred this issue from dotnet/corefx Feb 1, 2020
@msftgits msftgits added this to the 3.0 milestone Feb 1, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Dec 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-Infrastructure-libraries enhancement Product code improvement that does NOT require public API changes/additions
Projects
None yet
Development

No branches or pull requests

2 participants