This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
Port to 2.1 - Fix performance regression in Guid.NewGuid on OSX #29457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have recently removed dependency on the libuuid for Guid creation. Unfortunately, while the perf on Linux has improved, we have not noticed that the perf on OSX degraded 10 fold. This change fixes it by modifying the implementation of the underlying SystemNative_GetNonCryptographicallySecureRandomBytes to use arc4random like the uuid_generate_random that we were using before the libuuid dependency removal does.
stephentoub
approved these changes
May 2, 2018
|
OSX x64 Debug Build failure is https://github.com/dotnet/corefx/issues/27064 which was fixed in master with #29238. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have recently removed dependency on the libuuid for Guid creation. Unfortunately,
while the perf on Linux has improved, we have not noticed that the perf on OSX
degraded 10 fold.
This change fixes it by modifying the implementation of the underlying
SystemNative_GetNonCryptographicallySecureRandomBytes to use arc4random
like the uuid_generate_random that we were using before the libuuid dependency
removal does.
Fixes https://github.com/dotnet/corefx/issues/29427