This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
Several Http test fixes to hopefully improve test reliability #29238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add “Connection: close\r\n” response header in more cases where the loopback server explicitly closes a connection, and in particular where the client makes multiple connections. - Change several Task.WaitAlls on paired tasks to instead use our WhenAllOrAnyFailed helper.
davidsh
approved these changes
Apr 20, 2018
|
@dotnet-bot test Outerloop Windows x64 Debug Build please |
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
…/corefx#29238) - Add “Connection: close\r\n” response header in more cases where the loopback server explicitly closes a connection, and in particular where the client makes multiple connections. - Change several Task.WaitAlls on paired tasks to instead use our WhenAllOrAnyFailed helper. Commit migrated from dotnet/corefx@cebcf43
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/dotnet/corefx/issues/27064 (hopefully).
The failure from https://github.com/dotnet/corefx/issues/9543 also appears to now be much more deterministic; at least with WinHttpHandler the failure now repros for me every time.
cc: @davidsh, @geoffkizer