This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
Fix initializing BuildTools when the Platform environment variable is set #24998
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jashook
approved these changes
Jun 6, 2019
sbomer
approved these changes
Jun 6, 2019
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
… set (dotnet/coreclr#24998) * Make build-test.cmd exit if init-tools.cmd fails * Clear Platform variable before initializing BuildTools Commit migrated from dotnet/coreclr@a0486f5
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Platformvariable before initializing BuildToolsbuild-test.cmdexit ifinit-tools.cmdfailsSome BuildTools initialization steps fail if
Platformis set to a value with which they are not compatible. We were relying ondotnet.cmdto clear thePlatformenvironment variable beforeinit-tools.cmdwas called.build-test.cmdwas always callinginit-tools.cmdin such a way that thePlatformvariable was not cleared, but generally the tools would previously have been initialized throughdotnet.cmd, so they would not be initialized again. With #24841, we stopped initializing BuildTools indotnet.cmd, so the call inbuild-test.cmdwas actually doing the initialization (and failing depending on how `Platform is set).Fixes #24943