This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
Remove BuildTools from product build #24841
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elinor-fung
force-pushed
the
product-noBuildTools
branch
from
8a6e861 to
b53328e
Compare
elinor-fung
force-pushed
the
product-noBuildTools
branch
from
b53328e to
2c836bb
Compare
elinor-fung
force-pushed
the
product-noBuildTools
branch
from
2c836bb to
965bf14
Compare
AaronRobinsonMSFT
approved these changes
May 30, 2019
elinor-fung
changed the title
jashook
approved these changes
May 30, 2019
hoyosjs
approved these changes
May 30, 2019
There was a problem hiding this comment.
Can confirm product build doesn't touch BuildTools at all on Windows for product build. I'm pretty sure this is the case for Linux too. Thanks @elinor-fung :)
|
Last commit that reset the checks was non-functional (updating a comment in a .cmd file). All checks were green before that. Merging now to kick off an official build sooner. |
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
* Remove BuildTools imports from product build * Split scripts for installing dotnet vs BuildTools Commit migrated from dotnet/coreclr@fa8383f
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Microsoft.Net.Compilers.Toolsetinit-dotnetscripts for initializing only dotnet (via Arcade)With this change, BuildTools will no longer be pulled down or used for the product build (only gets pulled down for tests).
cc @RussKeldorph