This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
Enable R2R testing in PRs. Workaround an issue with custom xunit.console.dll runner. #23848
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
echesakov
changed the title
|
@RussKeldorph @sergiy-k |
RussKeldorph
approved these changes
Apr 11, 2019
davmason
pushed a commit
to davmason/coreclr
that referenced
this pull request
Apr 27, 2019
…e with custom xunit.console.dll runner. (dotnet#23848)
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
…e with custom xunit.console.dll runner. (dotnet/coreclr#23848) Commit migrated from dotnet/coreclr@1660956
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables ReadyToRun testing running aganst pull requests for:
Also excludes xunit.* files from being crossgen-d.
An issue we saw in https://github.com/dotnet/coreclr/issues/20797 and #20975 now happens again here.
I will work on the permanent solution for the issue.
However, we need to get R2R testing on Linux/macOS green asap, so temporary excluding System.Xml.XDocument.dll to workaround this.