Skip to content
This repository has been archived by the owner on Jan 23, 2023. It is now read-only.

Specify version of xunit.console.dll during the custom build #20975

Merged
merged 3 commits into from
Nov 13, 2018
Merged

Specify version of xunit.console.dll during the custom build #20975

merged 3 commits into from
Nov 13, 2018

Conversation

echesakov
Copy link

@echesakov echesakov commented Nov 13, 2018

Thanks to @janvorli we know the reason of failures in https://github.com/dotnet/coreclr/issues/20797:

[9:05 AM] Jan Vorlicek
So, I can see that the function that it reports as missing is in xunit.runner.utility.netcoreapp10.dll. The difference between the one from your package and the one that I have in Core_Root is the version. And your xunit.console.dll references the xunit.runner.utility.netcoreapp10.dll of version 99.99.99.0 while the xunit.runner.utility.netcoreapp10.dll that I had in Core_Root was 2.4.1.4059.
Maybe R2R is more sensitive to the versions than non-R2R, which could explain the difference.

This PR switches to using custom xunit.console.dll with specified assembly version (v2.4.1) during the build and update our dependencies.props to use stable Xunit v2.4.1

Fixes #20797

@echesakov
Copy link
Author

@dotnet-bot test Ubuntu16.04 arm64 Cross Checked r2r Build and Test
@dotnet-bot test Ubuntu arm Cross Checked r2r Build and Test

@dotnet-bot test Windows_NT x64 Checked r2r
@dotnet-bot test Windows_NT x64 Release r2r

@dotnet-bot test Windows_NT x86 Checked r2r
@dotnet-bot test Windows_NT x86 Release r2r

@dotnet-bot test CentOS7.1 x64 Checked r2r
@dotnet-bot test Ubuntu x64 Checked r2r

@echesakov echesakov changed the title [WIP] Specify xunit console dll version [WIP] Specify version of xunit.console.dll Nov 13, 2018
@echesakov
Copy link
Author

@dotnet-bot test Ubuntu16.04 arm64 Cross Checked r2r Build and Test
@dotnet-bot test Ubuntu arm Cross Checked r2r Build and Test

@dotnet-bot test Windows_NT x64 Checked r2r
@dotnet-bot test Windows_NT x64 Release r2r
@dotnet-bot test Windows_NT x86 Checked r2r
@dotnet-bot test Windows_NT x86 Release r2r

@dotnet-bot test CentOS7.1 x64 Checked r2r
@dotnet-bot test Ubuntu x64 Checked r2r

@echesakov
Copy link
Author

@dotnet-bot test CentOS7.1 x64 Checked r2r

@echesakov
Copy link
Author

test OSX10.12 x64 Checked Innerloop Build and Test

@echesakov echesakov changed the title [WIP] Specify version of xunit.console.dll Specify version of xunit.console.dll during the custom build Nov 13, 2018
@echesakov
Copy link
Author

Windows_NT x64 Release R2R Build and Test and Windows_NT x86 Release R2R Build and Test are test failures

@echesakov echesakov merged commit 124a8b9 into dotnet:master Nov 13, 2018
@echesakov echesakov deleted the SpecifyXunitConsoleDllVersion branch November 13, 2018 22:50
picenka21 pushed a commit to picenka21/runtime that referenced this pull request Feb 18, 2022
…coreclr#20975)

* Use stable Xunit v2.4.1
* Use xunit.console.dll with specified assembly version to avoid issues with Ready2Run jobs
* Update comment regarding building xunit with specified version in tests/runtest.py


Commit migrated from dotnet/coreclr@124a8b9
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants