Merging internal commits for release/6.0 #47652

vseanreesermsft · 2023-04-11T17:28:38Z

No description provided.

…t-efcore

…t-runtime

…t-efcore

Merge from public release/6.0 to internal/release/6.0 and resolve conflicts if necessary

…t-runtime

…t-efcore

…t-runtime

…ng/internal/dotnet-runtime This pull request updates the following dependencies [marker]: <> (Begin:7745f62d-e15b-4ba3-39b3-08d960f4ca81) ## From https://dev.azure.com/dnceng/internal/_git/dotnet-runtime - **Subscription**: 7745f62d-e15b-4ba3-39b3-08d960f4ca81 - **Build**: 20230323.11 - **Date Produced**: March 24, 2023 6:12:38 PM UTC - **Commit**: 1e620a42e71ca8c7efb033fd525f04be5fa701fe - **Branch**: refs/heads/internal/release/6.0 [DependencyUpdate]: <> (Begin) - **Updates**: - **Microsoft.Internal.Runtime.AspNetCore.Transport**: [from 6.0.16-servicing.23170.9 to 6.0.16-servicing.23173.11][1] - **Microsoft.NET.Runtime.MonoAOTCompiler.Task**: [from 6.0.16 to 6.0.16][1] - **Microsoft.NET.Runtime.WebAssembly.Sdk**: [from 6.0.16 to 6.0.16][1] - **Microsoft.NETCore.App.Ref**: [from 6.0.16 to 6.0.16][1] - **Microsoft.NETCore.App.Runtime.AOT.win-x64.Cross.browser-wasm**: [from 6.0.16 to 6.0.16][1] - **Microsoft.NETCore.App.Runtime.win-x64**: [from 6.0.16 to 6.0.16][1] - **Microsoft.NETCore.BrowserDebugHost.Transport**: [from 6.0.16-servicing.23170.9 to 6.0.16-servicing.23173.11][1] - **Microsoft.NETCore.Platforms**: [from 6.0.9 to 6.0.9][1] [1]: https://dev.azure.com/dnceng/internal/_git/dotnet-runtime/branches?baseVersion=GC567ff53ac7&targetVersion=GC1e620a42e7&_a=files [DependencyUpdate]: <> (End) [marker]: <> (End:7745f62d-e15b-4ba3-39b3-08d960f4ca81)

…-merge-6.0-2023-04-11-1028

ghost · 2023-04-11T17:28:47Z

Hi @vseanreesermsft. If this is not a tell-mode PR, please make sure to follow the instructions laid out in the servicing process document.
Otherwise, please add tell-mode label.

ghost · 2023-04-11T17:28:52Z

Hey @dotnet/aspnet-build, looks like this PR is something you want to take a look at.

wtgodbe · 2023-04-11T19:05:26Z

Got some Components-e2e failures, @MackinnonBuck could you take a look?

Microsoft.AspNetCore.Components.E2ETest.Tests.ComponentRenderingTest.CanHandleClearedChild

Assert.DoesNotContain() Failure
Found: (filter expression)
In value: ReadOnlyCollection [[2023-04-11T18:43:04Z] [Info] http://127.0.0.1:42599/subdir/_framework/blazor.webassembly.js 0:35640 "Handle blur...", [2023-04-11T18:43:09Z] [Debug] http://127.0.0.1:42599/subdir/_framework/dotnet.6.0.16.abslel8s2o.js 0:131187 "mono_wasm_runtime_ready" "fe00e07a-5519-4dfe-b35a-f867dbaf2e28", [2023-04-11T18:43:09Z] [Severe] http://127.0.0.1:42599/subdir/_framework/dotnet.6.0.16.abslel8s2o.js 0:17630 "/__w/1/s/src/mono/mono/eglib/gpath.c:115 \u003Cdisabled>", [2023-04-11T18:43:09Z] [Severe] http://127.0.0.1:42599/subdir/_framework/dotnet.6.0.16.abslel8s2o.js 0:17630 "/__w/1/s/src/mono/mono/eglib/gpath.c:115 \u003Cdisabled>"]

MackinnonBuck · 2023-04-11T20:58:43Z

Looks like some tests are failing because there are errors in the console.

@pavelsavara Do you know what might be happening here? From what I can tell, application functionality hasn't broken in any way other than outputting this error in the console.

dotnet.6.0.16.9vxckk6r1z.js:1  /__w/1/s/src/mono/mono/eglib/gpath.c:115 <disabled>
580850 @ dotnet.6.0.16.9vxckk6r1z.js:1
_emscripten_asm_const_int @ dotnet.6.0.16.9vxckk6r1z.js:1
$func111 @ dotnet.wasm:0x94bd
$func2230 @ dotnet.wasm:0x8ebb3
$func3483 @ dotnet.wasm:0xcc2e7
$func3484 @ dotnet.wasm:0xcc318
$func3485 @ dotnet.wasm:0xcc34b
$func3552 @ dotnet.wasm:0xcd83e
$func2078 @ dotnet.wasm:0x862e3
$func2076 @ dotnet.wasm:0x85de1
$func1338 @ dotnet.wasm:0x653d0
$func328 @ dotnet.wasm:0x255f4
$func310 @ dotnet.wasm:0x1eb55
$func361 @ dotnet.wasm:0x27e5b
$func214 @ dotnet.wasm:0x1a03b
$func167 @ dotnet.wasm:0x18991
$func166 @ dotnet.wasm:0xbd73
$func2815 @ dotnet.wasm:0xabef4
$func1619 @ dotnet.wasm:0x6fcb4
$func1623 @ dotnet.wasm:0x70321
$func3217 @ dotnet.wasm:0xc4e86
$mono_background_exec @ dotnet.wasm:0x9433f
Module._mono_background_exec @ dotnet.6.0.16.9vxckk6r1z.js:1
pump_message @ dotnet.6.0.16.9vxckk6r1z.js:1
setTimeout (async)
_schedule_background_exec @ dotnet.6.0.16.9vxckk6r1z.js:1
$func2392 @ dotnet.wasm:0x942f0
$func3216 @ dotnet.wasm:0xc4e16
$func219 @ dotnet.wasm:0x1a529
$func167 @ dotnet.wasm:0xce8f
$func166 @ dotnet.wasm:0xbd73
$func2815 @ dotnet.wasm:0xabef4
$func1619 @ dotnet.wasm:0x6fcb4
$func1623 @ dotnet.wasm:0x70321
$mono_wasm_invoke_method @ dotnet.wasm:0x969f
Module._mono_wasm_invoke_method @ dotnet.6.0.16.9vxckk6r1z.js:1
_call_method_with_converted_args @ dotnet.6.0.16.9vxckk6r1z.js:1
call_method @ dotnet.6.0.16.9vxckk6r1z.js:1
(anonymous) @ dotnet.6.0.16.9vxckk6r1z.js:1
call_assembly_entry_point @ dotnet.6.0.16.9vxckk6r1z.js:1
callEntryPoint @ MonoPlatform.ts:61
At @ Boot.WebAssembly.ts:135
await in At (async)
(anonymous) @ Boot.WebAssembly.ts:218
(anonymous) @ blazor.webassembly.js:1

pavelsavara · 2023-04-12T07:41:54Z

I don't know yet.

@kg @radekdoulik any thoughts ?

pavelsavara · 2023-04-12T07:44:04Z

/mono/mono/eglib/gpath.c:115 is g_path_get_dirname with NULL filename

lewing · 2023-04-12T22:04:16Z

@elinor-fung I think this is the dllimport change breaking blazor

elinor-fung · 2023-04-12T22:24:44Z

Looks like 6.0 didn't have the null check: dotnet/runtime#60445

Just to double check - this is a log message, not a 'crashing the world', right?

wtgodbe · 2023-04-12T22:49:59Z

Test failure fixed by dotnet/runtime#84740

lewing · 2023-04-12T23:30:31Z

Looks like 6.0 didn't have the null check: dotnet/runtime#60445

Just to double check - this is a log message, not a 'crashing the world', right?

no this is crashing the world when that path gets hit

ghost · 2023-04-12T23:30:35Z

Hi @lewing. It looks like you just commented on a closed PR. The team will most probably miss it. If you'd like to bring something important up to their attention, consider filing a new issue and add enough details to build context.

dotnet-bot and others added 23 commits March 7, 2023 22:17

Merge in 'release/6.0' changes

f0b89db

Merge in 'release/6.0' changes

48345db

[internal/release/6.0] Update dependencies from dnceng/internal/dotne…

92609a4

…t-efcore

Merge in 'release/6.0' changes

03626ad

Merge in 'release/6.0' changes

fb6bff7

Merge in 'release/6.0' changes

e40b13e

[internal/release/6.0] Update dependencies from dnceng/internal/dotne…

f971c03

…t-runtime

[internal/release/6.0] Update dependencies from dnceng/internal/dotne…

2e6b193

…t-runtime

[internal/release/6.0] Update dependencies from dnceng/internal/dotne…

98b903b

…t-runtime

[internal/release/6.0] Update dependencies from dnceng/internal/dotne…

23cbd6b

…t-runtime

[internal/release/6.0] Update dependencies from dnceng/internal/dotne…

798ac3d

…t-runtime

[internal/release/6.0] Update dependencies from dnceng/internal/dotne…

9c56c4a

…t-runtime

Merge in 'release/6.0' changes

92f3976

[internal/release/6.0] Update dependencies from dnceng/internal/dotne…

56b0b4a

…t-runtime

Merge in 'release/6.0' changes

0e2c1b3

[internal/release/6.0] Update dependencies from dnceng/internal/dotne…

732cd26

…t-efcore

Merged PR 30049: [internal/release/6.0] Merge from public

642c823

Merge from public release/6.0 to internal/release/6.0 and resolve conflicts if necessary

[internal/release/6.0] Update dependencies from dnceng/internal/dotne…

206b88e

…t-runtime

Merge in 'release/6.0' changes

bb8d881

[internal/release/6.0] Update dependencies from dnceng/internal/dotne…

7a292a4

…t-efcore

[internal/release/6.0] Update dependencies from dnceng/internal/dotne…

41a6490

…t-runtime

Merge commit 'd6f154cca3863703cf87c8b840eea9cbe20229b2' into internal…

017655f

…-merge-6.0-2023-04-11-1028

vseanreesermsft requested a review from wtgodbe as a code owner April 11, 2023 17:28

dotnet-issue-labeler bot added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Apr 11, 2023

ghost added this to the 6.0.x milestone Apr 11, 2023

Update baseline/SDK

708a0fa

wtgodbe requested a review from a team as a code owner April 11, 2023 17:55

lewing mentioned this pull request Apr 12, 2023

Skip DllImportSearchPathsTest on wasm dotnet/runtime#84735

Merged

wtgodbe merged commit 5629320 into dotnet:release/6.0 Apr 12, 2023

ghost modified the milestones: 6.0.x, 6.0.17 Apr 12, 2023

lewing mentioned this pull request Apr 12, 2023

[release/6.0] Fix null being passed to g_path_get_dirname when probing in wasm dotnet/runtime#84740

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Merging internal commits for release/6.0 #47652

Merging internal commits for release/6.0 #47652

vseanreesermsft commented Apr 11, 2023

ghost commented Apr 11, 2023

ghost commented Apr 11, 2023

wtgodbe commented Apr 11, 2023 •

edited

Loading

MackinnonBuck commented Apr 11, 2023 •

edited

Loading

pavelsavara commented Apr 12, 2023

pavelsavara commented Apr 12, 2023

lewing commented Apr 12, 2023

elinor-fung commented Apr 12, 2023

wtgodbe commented Apr 12, 2023

lewing commented Apr 12, 2023 •

edited

Loading

ghost commented Apr 12, 2023

Merging internal commits for release/6.0 #47652

Merging internal commits for release/6.0 #47652

Conversation

vseanreesermsft commented Apr 11, 2023

ghost commented Apr 11, 2023

ghost commented Apr 11, 2023

wtgodbe commented Apr 11, 2023 • edited Loading

MackinnonBuck commented Apr 11, 2023 • edited Loading

pavelsavara commented Apr 12, 2023

pavelsavara commented Apr 12, 2023

lewing commented Apr 12, 2023

elinor-fung commented Apr 12, 2023

wtgodbe commented Apr 12, 2023

lewing commented Apr 12, 2023 • edited Loading

ghost commented Apr 12, 2023

wtgodbe commented Apr 11, 2023 •

edited

Loading

MackinnonBuck commented Apr 11, 2023 •

edited

Loading

lewing commented Apr 12, 2023 •

edited

Loading