Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix null being passed to g_path_get_dirname when probing in wasm #60445

Merged
merged 2 commits into from
Oct 15, 2021
Merged

Fix null being passed to g_path_get_dirname when probing in wasm #60445

merged 2 commits into from
Oct 15, 2021

Conversation

kg
Copy link
Member

@kg kg commented Oct 14, 2021

Somewhat recently the module probing logic started passing null to g_path_get_dirname in some cases. While this wouldn't crash, it would print an error to the console.

cc @lambdageek

@kg kg added the arch-wasm WebAssembly architecture label Oct 14, 2021
@ghost
Copy link

ghost commented Oct 14, 2021

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

Somewhat recently the module probing logic started passing null to g_path_get_dirname in some cases. While this wouldn't crash, it would print an error to the console.

cc @lambdageek

Author: kg
Assignees: -
Labels:

arch-wasm
Milestone: -

lambdageek
lambdageek approved these changes Oct 15, 2021
View reviewed changes
Copy link
Member

@lambdageek lambdageek left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit1: indentation

nit2: (I realize this was on the old version - we should clean it up) a & b && c is kind of sus. (a & b) != 0 && c is better.

@kg kg merged commit 027ea7f into dotnet:main Oct 15, 2021
@pavelsavara
Copy link
Member

Does this fix #60392 ?

@ilonatommy
Copy link
Member

Fixes #60392

@lambdageek lambdageek mentioned this pull request Oct 18, 2021
Closed
@runfoapp runfoapp bot mentioned this pull request Oct 18, 2021
Closed
@ghost ghost locked as resolved and limited conversation to collaborators Nov 17, 2021
@elinor-fung elinor-fung mentioned this pull request Apr 12, 2023
Merged
@lewing
Copy link
Member

lewing commented Apr 12, 2023

/backport to release/6.0-staging

@github-actions github-actions bot unlocked this conversation Apr 12, 2023
@github-actions
Copy link
Contributor

Started backporting to release/6.0-staging: https://github.com/dotnet/runtime/actions/runs/4683579945

@github-actions github-actions bot mentioned this pull request Apr 12, 2023
Merged
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lambdageek lambdageek lambdageek approved these changes

@vargaz vargaz vargaz approved these changes

@thaystg thaystg Awaiting requested review from thaystg thaystg is a code owner

Assignees
No one assigned
Labels
arch-wasm WebAssembly architecture area-AssemblyLoader-mono
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@kg @pavelsavara @ilonatommy @lewing @vargaz @lambdageek