-
Notifications
You must be signed in to change notification settings - Fork 10.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove IKestrelTrace #37242
Remove IKestrelTrace #37242
Conversation
Why do we still have kestrel trace? |
It wraps a bunch of differently named loggers: aspnetcore/src/Servers/Kestrel/Core/src/Internal/Infrastructure/KestrelTrace.cs Lines 13 to 28 in cd8e890
It could be split out into BadRequestsLog, Http2Log, etc, but I think a centralized type that ensures the right logger is used for each log message seems worthwhile. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very happy to see these test trace classes gone.
Fixes #31581
Yeet IKestrelTrace and associated implementations.
TODO:
I will do the same for SocketsTrace and QuicTrace in future PRs.