-
Notifications
You must be signed in to change notification settings - Fork 10.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove IKestrelTrace #31581
Comments
Thanks for contacting us. |
@gfoidl want to take a stab at this? |
I'll give it a try 😃 |
Once #31596 is merged, I'm starting, otherwise there'll be a merge conflict. |
Thanks for the info! |
Update: I'd like to wait on dotnet/runtime#51927. This unblocks the usage here for source generators. |
@gfoidl Are you still interested in taking on this issue? |
Also, Kestrel and transport logs have been updated to use source generators. |
Yes, my interest is still there, but I'm a bit sick at the moment (and my brain not working at the level I'd like it to work). So I won't start before next week. |
@gfoidl Sorry to hear that you're not feeling well, and hope you get better soon. Please don't feel rushed to work on this until you are fully recovered. I'm going to change the milestone for now just for tracking purposes. We can add a milestone again once we know when it'll land. |
We've moved this issue to the Backlog milestone. This means that it is not going to be worked on for the coming release. We will reassess the backlog following the current release and consider this item at that time. To learn more about our issue management process and to have better expectation regarding different types of issues you can read our Triage Process. |
IKestralTrace was added before it was easily possible to unit test logs.
See #31562 (comment)
We should remove the interface and change KestrelTrace into a static class. Will save making interface method calls.
Will likely require a lot of changes to unit tests.
Repeat for ISocketTrace and IQuicTrace.
The text was updated successfully, but these errors were encountered: