Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove IKestrelTrace #31581

Closed
JamesNK opened this issue Apr 7, 2021 · 13 comments · Fixed by #37242
Closed

Remove IKestrelTrace #31581

JamesNK opened this issue Apr 7, 2021 · 13 comments · Fixed by #37242
Labels
area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions feature-kestrel help wanted Up for grabs. We would accept a PR to help resolve this issue
Milestone

Comments

@JamesNK
Copy link
Member

JamesNK commented Apr 7, 2021

IKestralTrace was added before it was easily possible to unit test logs.

See #31562 (comment)

We should remove the interface and change KestrelTrace into a static class. Will save making interface method calls.

Will likely require a lot of changes to unit tests.

Repeat for ISocketTrace and IQuicTrace.

@JamesNK
Copy link
Member Author

JamesNK commented Apr 7, 2021

@davidfowl @halter73

@davidfowl davidfowl added help wanted Up for grabs. We would accept a PR to help resolve this issue feature-kestrel labels Apr 7, 2021
@BrennanConroy BrennanConroy added this to the Next sprint planning milestone Apr 7, 2021
@ghost
Copy link

ghost commented Apr 7, 2021

Thanks for contacting us.
We're moving this issue to the Next sprint planning milestone for future evaluation / consideration. Because it's not immediately obvious that this is a bug in our framework, we would like to keep this around to collect more feedback, which can later help us determine the impact of it. We will re-evaluate this issue, during our next planning meeting(s).
If we later determine, that the issue has no community involvement, or it's very rare and low-impact issue, we will close it - so that the team can focus on more important and high impact issues.
To learn more about what to expect next and how this issue will be handled you can read more about our triage process here.

@davidfowl
Copy link
Member

@gfoidl want to take a stab at this?

@gfoidl
Copy link
Member

gfoidl commented Apr 8, 2021

I'll give it a try 😃

@gfoidl
Copy link
Member

gfoidl commented Apr 8, 2021

Once #31596 is merged, I'm starting, otherwise there'll be a merge conflict.

@fvoronin
Copy link
Contributor

@gfoidl, JFYI, #31596 was merged

@gfoidl
Copy link
Member

gfoidl commented Apr 23, 2021

Thanks for the info!
Will start soon working on it -- and will look into #32087 as well.

@gfoidl
Copy link
Member

gfoidl commented May 5, 2021

Update: I'd like to wait on dotnet/runtime#51927. This unblocks the usage here for source generators.

@adityamandaleeka
Copy link
Member

@gfoidl Are you still interested in taking on this issue?

@JamesNK
Copy link
Member Author

JamesNK commented Aug 3, 2021

Also, Kestrel and transport logs have been updated to use source generators.

#34910

@gfoidl
Copy link
Member

gfoidl commented Aug 4, 2021

Yes, my interest is still there, but I'm a bit sick at the moment (and my brain not working at the level I'd like it to work). So I won't start before next week.

@adityamandaleeka
Copy link
Member

@gfoidl Sorry to hear that you're not feeling well, and hope you get better soon. Please don't feel rushed to work on this until you are fully recovered.

I'm going to change the milestone for now just for tracking purposes. We can add a milestone again once we know when it'll land.

@ghost
Copy link

ghost commented Aug 4, 2021

We've moved this issue to the Backlog milestone. This means that it is not going to be worked on for the coming release. We will reassess the backlog following the current release and consider this item at that time. To learn more about our issue management process and to have better expectation regarding different types of issues you can read our Triage Process.

@ghost ghost locked as resolved and limited conversation to collaborators Nov 5, 2021
@amcasey amcasey added area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions and removed area-runtime labels Jun 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions feature-kestrel help wanted Up for grabs. We would accept a PR to help resolve this issue
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants