-
Notifications
You must be signed in to change notification settings - Fork 10k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use MetadataUpdater.IsSupported to determine if application supports … #34022
Conversation
70d6f43
to
5073e12
Compare
Thank you for submitting this for API review. This will be reviewed by @dotnet/aspnet-api-review at the next meeting of the ASP.NET Core API Review group. Please ensure you take a look at the API review process documentation and ensure that:
|
3537559
to
798af0f
Compare
798af0f
to
be8318c
Compare
@@ -40,7 +40,7 @@ Microsoft.AspNetCore.Components.NavigationOptions.ForceLoad.init -> void | |||
Microsoft.AspNetCore.Components.NavigationOptions.NavigationOptions() -> void | |||
Microsoft.AspNetCore.Components.NavigationOptions.ReplaceHistoryEntry.get -> bool | |||
Microsoft.AspNetCore.Components.NavigationOptions.ReplaceHistoryEntry.init -> void | |||
Microsoft.AspNetCore.Components.RenderHandle.IsHotReloading.get -> bool | |||
Microsoft.AspNetCore.Components.RenderHandle.IsRenderingOnMetadataUpdate.get -> bool |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The runtime is using MetadataUpdate
as the term for hot reload. Updated this API to use this nomenclature. Outside of this, this PR is fairly simple - it uses the new API and adds a test hook for code that currently relies on testing. Once the SDK change - dotnet/sdk#18810 lands, we're able to trim out all[1] references to hot reload specific code.
[1] Right now the test type with the property set to default ends up not being trimmed. But it seems like a small cost and I'll follow up to see if we can clear that up. I wouldn't block on it though.
Could I have this reviewed? It's an easy one. |
Co-authored-by: Safia Abdalla <[email protected]>
…hot reload
Fixes #33477