Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update code in ASP.NET Core that detect if the app is being hot reloaded #33477

Closed
pranavkm opened this issue Jun 11, 2021 · 0 comments · Fixed by #34022
Closed

Update code in ASP.NET Core that detect if the app is being hot reloaded #33477

pranavkm opened this issue Jun 11, 2021 · 0 comments · Fixed by #34022
Assignees
@pranavkm
Labels
area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates blocked The work on this issue is blocked due to some dependency Done This issue has been fixed feature-hot-reload This issue is related to the Hot Reload feaature task
Milestone
6.0-preview7

Comments

@pranavkm
Copy link
Contributor

Based on the conversation here: #33386 (comment)

There's interest in consolidating checks to determine if the app is being HotReloaded. Blazor has a couple and MVC is adding another one as part of it. Instead of proliferating these checks, it would be good if we can consolidate these possibly as a runtime check. Runtime issue currently tracking this: dotnet/runtime#51159
@pranavkm pranavkm added the area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates label Jun 11, 2021
@pranavkm pranavkm mentioned this issue Jun 11, 2021
Merged
@mkArtakMSFT mkArtakMSFT added the feature-hot-reload This issue is related to the Hot Reload feaature label Jun 14, 2021
@mkArtakMSFT mkArtakMSFT added this to the 6.0-preview7 milestone Jun 14, 2021
@pranavkm pranavkm added the blocked The work on this issue is blocked due to some dependency label Jun 17, 2021
pranavkm added a commit that referenced this issue Jul 2, 2021
@pranavkm
Use MetadataUpdater.IsSupported to determine if application supports …
0ca7a9a 
…hot reload

Fixes #33477
@pranavkm pranavkm mentioned this issue Jul 2, 2021
Merged
@ghost ghost added the Working label Jul 2, 2021
pranavkm added a commit that referenced this issue Jul 7, 2021
@pranavkm
Use MetadataUpdater.IsSupported to determine if application supports …
5073e12 
…hot reload

Fixes #33477
pranavkm added a commit that referenced this issue Jul 7, 2021
@pranavkm
Use MetadataUpdater.IsSupported to determine if application supports …
798af0f 
…hot reload

Fixes #33477
pranavkm added a commit that referenced this issue Jul 9, 2021
@pranavkm
Use MetadataUpdater.IsSupported to determine if application supports …
be8318c 
…hot reload

Fixes #33477
@ghost ghost added the Done This issue has been fixed label Jul 11, 2021
pranavkm added a commit that referenced this issue Jul 11, 2021
@pranavkm @captainsafia
Use MetadataUpdater.IsSupported to determine if application supports … (
39dccd7 
#34022)

* Use MetadataUpdater.IsSupported to determine if application supports hot reload

Fixes #33477

* Update src/Components/Components/src/HotReload/HotReloadManager.cs

Co-authored-by: Safia Abdalla <[email protected]>

Co-authored-by: Safia Abdalla <[email protected]>
@ghost ghost removed the Working label Jul 11, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Aug 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@pranavkm pranavkm

Labels
area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates blocked The work on this issue is blocked due to some dependency Done This issue has been fixed feature-hot-reload This issue is related to the Hot Reload feaature task
Projects
None yet
Milestone
6.0-preview7
Development

Successfully merging a pull request may close this issue.

Use MetadataUpdater.IsSupported to determine if application supports … dotnet/aspnetcore
2 participants
@pranavkm @mkArtakMSFT