[release/8.0] Fix WithReference(Uri) environment variable name to match Service Discovery configuration format #3836
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
…covery configuration format
dotnet-issue-labeler
bot
added
the
area-app-model
dotnet-policy-service
bot
added
the
Servicing-consider
danmoseley
added
Servicing-approved
|
@danmoseley has approved merge. Can I get the requisite 2 (two) sign-offs on this? |
RussKie
approved these changes
Apr 19, 2024
danmoseley
approved these changes
Apr 20, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #3835 to release/8.0
/cc @ReubenBond
Customer Impact
This fixes a bug with
WithReference(Uri)where the URI will not be picked up by Service Discovery because the env var format changed in a previous release.Testing
We have a test case to ensure that the env var is as-expected, which was updated by this PR. We have Service Discovery tests which use for this configuration format. We do not have integration tests which use
WithReference(Uri)yet.Risk
If developers are already relying on the (wrong) behavior (manually inspecting env vars/config, not via Service Discovery), this will break them until they update their code to accommodate.
Regression?
Yes
Microsoft Reviewers: Open in CodeFlow