Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix WithReference(Uri) environment variable name to match Service Discovery configuration format #3835

Merged
merged 1 commit into from
Apr 19, 2024

Conversation

ReubenBond
Copy link
Member

@ReubenBond ReubenBond commented Apr 19, 2024

This is a left-over from #2719
The WithReference overload which accepts a URI must be updated to also adopt the newer Service Discovery configuration format. This PR updates it.

Microsoft Reviewers: Open in CodeFlow

@dotnet-issue-labeler dotnet-issue-labeler bot added the area-app-model Issues pertaining to the APIs in Aspire.Hosting, e.g. DistributedApplication label Apr 19, 2024
@ReubenBond ReubenBond enabled auto-merge (squash) April 19, 2024 15:27
@ReubenBond
Copy link
Member Author

/backport to release/8.0

Copy link
Contributor

Started backporting to release/8.0: https://github.com/dotnet/aspire/actions/runs/8756006344

@ReubenBond ReubenBond merged commit 73eace7 into main Apr 19, 2024
8 checks passed
@ReubenBond ReubenBond deleted the rebond/fix/apphost-withreference-uri branch April 19, 2024 15:52
@github-actions github-actions bot locked and limited conversation to collaborators May 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-app-model Issues pertaining to the APIs in Aspire.Hosting, e.g. DistributedApplication
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants