Port #1344 and #1398 (endpoint fixes in dashboard) to main #1401
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tlmii
requested review from
davidfowl,
drewnoakes,
smitpatel,
adamint and
kvenkatrajan
adamint
approved these changes
Dec 14, 2023
tlmii
commented
Dec 14, 2023
| @@ -55,3 +55,5 @@ public sealed class ResourceServiceSnapshot(string name, string? allocatedAddres | |||
| public int? AllocatedPort { get; } = allocatedPort; | |||
| public string AddressAndPort { get; } = $"{allocatedAddress}:{allocatedPort}"; | |||
| } | |||
|
|
|||
| public sealed record EndpointViewModel(string EndpointUrl, string ProxyUrl); | |||
There was a problem hiding this comment.
@drewnoakes Guessing with your refactorings and naming changes that this shouldn't be called EndpointViewModel anymore?
There was a problem hiding this comment.
This is night time for Drew. We can merge this and update in a separate PR when Drew replies back.
There was a problem hiding this comment.
I'm midway through that refactoring now, building on top of my latest PR. Please take a look at that PR if you have time, to help keep that work moving.
smitpatel
approved these changes
Dec 14, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Manually ports #1344 and #1398 to main so we're better in sync. There were some refactorings in main so it wasn't a straight cherry-pick.
Microsoft Reviewers: Open in CodeFlow