Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[8.0-preview2] Show proxy URL for all executables #1344

Merged
merged 1 commit into from
Dec 12, 2023
Merged

[8.0-preview2] Show proxy URL for all executables #1344

merged 1 commit into from
Dec 12, 2023

Conversation

smitpatel
Copy link
Contributor

@smitpatel smitpatel commented Dec 12, 2023 •
edited by davidfowl
Loading

For multiple replica, replica endpoint will be shown in bracket

Fixes #1335

image

Microsoft Reviewers: Open in CodeFlow

@smitpatel
Show proxy URL for all executables
626b193 
For multiple replica, replica endpoint will be shown in bracket

Resolves #1335
@smitpatel smitpatel changed the title Show proxy URL for all executables [8.0-preview2] Show proxy URL for all executables Dec 12, 2023
DamianEdwards
DamianEdwards approved these changes Dec 12, 2023
View reviewed changes
Copy link
Member

@DamianEdwards DamianEdwards left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked out the branch locally and verified the proxy URLs for no-replica & replica projects worked, as well as the instance URLs for replicas.

@davidfowl davidfowl merged commit fd0605e into release/8.0-preview2 Dec 12, 2023
8 checks passed
@davidfowl davidfowl deleted the smit/endpointfix branch December 12, 2023 01:26
@eerhardt
Copy link
Member

@smitpatel - did this change also make it into main? If not, it will be lost in the next preview.

@davidfowl davidfowl linked an issue Dec 12, 2023 that may be closed by this pull request
Dashboard is showing endpoint URL for application instead of the proxy #1335
Closed
@joperezr
Copy link
Member

@smitpatel Smit Patel FTE - did this change also make it into main? If not, it will be lost in the next preview.

We actually do a merge back from release branches to main once we release in order to not miss things

@smitpatel
Copy link
Contributor Author

@eerhardt @joperezr - This change is not in main. What should I do here process wise?

  • Submit similar fix PR to main branch?
  • Submit PR to merge release to main branch? (Would some other mechanism do it?)

This was referenced Dec 14, 2023
Merged
Merged
@github-actions github-actions bot locked and limited conversation to collaborators Apr 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@DamianEdwards DamianEdwards DamianEdwards approved these changes

@davidfowl davidfowl davidfowl approved these changes

@tlmii tlmii Awaiting requested review from tlmii

Assignees
No one assigned
Labels
area-dashboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Dashboard is showing endpoint URL for application instead of the proxy
5 participants
@smitpatel @eerhardt @joperezr @davidfowl @DamianEdwards