Rewrite GitHub webooks using Octokit.Webhooks #4111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
premun
reviewed
Oct 29, 2024
...onstructionService/ProductConstructionService.Api/Controllers/GitHubWebhookEventProcessor.cs
Outdated
Show resolved
Hide resolved
...onstructionService/ProductConstructionService.Api/Controllers/GitHubWebhookEventProcessor.cs
Outdated
Show resolved
Hide resolved
...onstructionService/ProductConstructionService.Api/Controllers/GitHubWebhookEventProcessor.cs
Outdated
Show resolved
Hide resolved
...onstructionService/ProductConstructionService.Api/Controllers/GitHubWebhookEventProcessor.cs
Outdated
Show resolved
Hide resolved
…Controllers/GitHubWebhookEventProcessor.cs Co-authored-by: Přemek Vysoký <[email protected]>
…Controllers/GitHubWebhookEventProcessor.cs Co-authored-by: Přemek Vysoký <[email protected]>
…repa/GitHubWebhooks
premun
previously approved these changes
Oct 29, 2024
...onstructionService/ProductConstructionService.Api/Controllers/GitHubWebhookEventProcessor.cs
Outdated
Show resolved
Hide resolved
premun
reviewed
Oct 29, 2024
src/ProductConstructionService/ProductConstructionService.Api/PcsStartup.cs
Outdated
Show resolved
Hide resolved
premun
previously approved these changes
Oct 29, 2024
premun
reviewed
Oct 29, 2024
src/ProductConstructionService/ProductConstructionService.Api/PcsStartup.cs
Outdated
Show resolved
Hide resolved
premun
previously approved these changes
Oct 29, 2024
premun
previously approved these changes
Oct 29, 2024
src/ProductConstructionService/ProductConstructionService.Api/Program.cs
Outdated
Show resolved
Hide resolved
…Program.cs Co-authored-by: Přemek Vysoký <[email protected]>
premun
approved these changes
Oct 29, 2024
This was referenced Oct 29, 2024
|
Rolled out with #4125 |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#4066
I validated these changes by pointing the staging app to PCS, and installing it in my fork.
The request returned a 200, and I'm seeing the entry in staging BAR.
The only thing I didn't test is my latest commit, where I changed the endpoint path from the default one, to the one we're currently using, just to keep things consistent. Will test that too before merging