Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate Maestro to Octokit.Webhooks #3527

Closed
JamieMagee opened this issue May 6, 2024 · 3 comments
Closed

Migrate Maestro to Octokit.Webhooks #3527

JamieMagee opened this issue May 6, 2024 · 3 comments
Assignees

Comments

@JamieMagee
Copy link
Member

Maestro currently uses the Microsoft.AspNetCore.WebHooks.Receivers.GitHub package to receive and process GitHub webhooks. This package has been deprecated as part of the .NET package maintenance effort1.

GitHub now has an official Octokit.Webhooks (and Octokit.Webhooks.AspNetCore) package2 that's actively being supported. In the long-term, Maestro should probably be migrated to use the official upstream package.

Footnotes

  1. https://github.com/dotnet/announcements/issues/217

  2. https://github.com/octokit/webhooks.net

@premun
Copy link
Member

premun commented Jun 13, 2024

Thanks for the heads up!

@dkurepa
Copy link
Member

dkurepa commented Oct 29, 2024

PR for this issue #4111. We're only changing this on PCS, since Maestro will get shut down soon

@dkurepa
Copy link
Member

dkurepa commented Nov 4, 2024

The PR above was merged, finishing this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants