Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dev | Improved connection timeout #2098

Merged
merged 6 commits into from
Aug 22, 2023

Merge branch 'main' of https://github.com/dotnet/SqlClient into timeout

4b1e43e
Select commit
Loading
Failed to load commit list.
Merged

Dev | Improved connection timeout #2098

Merge branch 'main' of https://github.com/dotnet/SqlClient into timeout
4b1e43e
Select commit
Loading
Failed to load commit list.
Azure Pipelines / CI-SqlClient succeeded Aug 22, 2023 in 4h 3m 54s

Build #23307 had test failures

9 errors / 10 warnings

Details

Tests

  • Failed: 3 (0.00%)
  • Passed: 311,242 (98.61%)
  • Other: 4,369 (1.38%)
  • Total: 315,614
Code coverage

  • 79003 of 111634 lines covered (70.77%)

Annotations

Check failure on line 0 in EXEC

See this annotation in the file changed.

@azure-pipelines azure-pipelines / CI-SqlClient

EXEC#L0 

EXEC(0,0): Error Message:

Check failure on line 187 in build.proj

See this annotation in the file changed.

@azure-pipelines azure-pipelines / CI-SqlClient

build.proj#L187 

build.proj(187,5): Error MSB3073: The command "dotnet test "src\Microsoft.Data.SqlClient\tests\ManualTests\Microsoft.Data.SqlClient.ManualTesting.Tests.csproj" -p:Configuration=Release -p:TargetnetcoreVersion=net7.0 --no-build -l "console;verbosity=normal" --collect "Code coverage" -p:TestSet=2 --results-directory TestResults -p:TestTargetOS=Windowsnetcoreapp --filter "category!=nonnetcoreapptests&category!=failing&category!=nonwindowstests" "--logger:trx;LogFilePrefix=Manual-Windowsnetcoreapp-2"" exited with code 1.

Check failure on line 3878 in Build log

See this annotation in the file changed.

@azure-pipelines azure-pipelines / CI-SqlClient

Build log #L3878 

Process 'msbuild.exe' exited with code '1'.

Check failure on line 0 in EXEC

See this annotation in the file changed.

@azure-pipelines azure-pipelines / CI-SqlClient

EXEC#L0 

EXEC(0,0): Error Message:

Check failure on line 1 in Microsoft.Data.SqlClient.ManualTesting.Tests.ConnectionExceptionTest.TestConnectionStateWithErrorClass20

See this annotation in the file changed.

@azure-pipelines azure-pipelines / CI-SqlClient

Microsoft.Data.SqlClient.ManualTesting.Tests.ConnectionExceptionTest.TestConnectionStateWithErrorClass20 

Assert.Equal() Failure
Expected: 11
Actual:   20
Raw output 
   at Microsoft.Data.SqlClient.ManualTesting.Tests.ConnectionExceptionTest.TestConnectionStateWithErrorClass20() in D:\a\_work\1\s\src\Microsoft.Data.SqlClient\tests\ManualTests\SQL\ExceptionTest\ConnectionExceptionTest.cs:line 43
   at System.RuntimeMethodHandle.InvokeMethod(Object target, Void** arguments, Signature sig, Boolean isConstructor)
   at System.Reflection.MethodInvoker.Invoke(Object obj, IntPtr* args, BindingFlags invokeAttr)

Check failure on line 1 in Microsoft.Data.SqlClient.ManualTesting.Tests.ConnectionExceptionTest.TestConnectionStateWithErrorClass20

See this annotation in the file changed.

@azure-pipelines azure-pipelines / CI-SqlClient

Microsoft.Data.SqlClient.ManualTesting.Tests.ConnectionExceptionTest.TestConnectionStateWithErrorClass20 

Assert.Equal() Failure
Expected: 11
Actual:   20
Raw output 
   at Microsoft.Data.SqlClient.ManualTesting.Tests.ConnectionExceptionTest.TestConnectionStateWithErrorClass20() in D:\a\_work\1\s\src\Microsoft.Data.SqlClient\tests\ManualTests\SQL\ExceptionTest\ConnectionExceptionTest.cs:line 43
   at System.RuntimeMethodHandle.InvokeMethod(Object target, Void** arguments, Signature sig, Boolean isConstructor)
   at System.Reflection.MethodInvoker.Invoke(Object obj, IntPtr* args, BindingFlags invokeAttr)

Check failure on line 1 in Microsoft.Data.SqlClient.ManualTesting.Tests.SqlConfigurationManagerReliabilityTest.InvalidRetryLogicTypeWithValidInternalMethodName(typeName: "Microsoft.Data.SqlClient.SqlConfigurableRetryFacto"...)

See this annotation in the file changed.

@azure-pipelines azure-pipelines / CI-SqlClient

Microsoft.Data.SqlClient.ManualTesting.Tests.SqlConfigurationManagerReliabilityTest.InvalidRetryLogicTypeWithValidInternalMethodName(typeName: "Microsoft.Data.SqlClient.SqlConfigurableRetryFacto"...) 

Assert.Throws() Failure
Expected: typeof(System.AggregateException)
Actual:   typeof(System.InvalidOperationException): ExecuteReader requires an open and available Connection. The connection's current state is closed.
---- System.InvalidOperationException : ExecuteReader requires an open and available Connection. The connection's current state is closed.
Raw output 
   at Microsoft.Data.SqlClient.SqlCommand.ValidateCommand(Boolean isAsync, String method) in D:\a\_work\1\s\src\Microsoft.Data.SqlClient\netcore\src\Microsoft\Data\SqlClient\SqlCommand.cs:line 5359
   at Microsoft.Data.SqlClient.SqlCommand.RunExecuteReader(CommandBehavior cmdBehavior, RunBehavior runBehavior, Boolean returnStream, TaskCompletionSource`1 completion, Int32 timeout, Task& task, Boolean& usedCache, Boolean asyncWrite, Boolean inRetry, String method) in D:\a\_work\1\s\src\Microsoft.Data.SqlClient\netcore\src\Microsoft\Data\SqlClient\SqlCommand.cs:line 4671
   at Microsoft.Data.SqlClient.SqlCommand.RunExecuteReader(CommandBehavior cmdBehavior, RunBehavior runBehavior, Boolean returnStream, String method) in D:\a\_work\1\s\src\Microsoft.Data.SqlClient\netcore\src\Microsoft\Data\SqlClient\SqlCommand.cs:line 4647
   at Microsoft.Data.SqlClient.SqlCommand.<>c__DisplayClass147_0.<RunExecuteReaderWithRetry>b__0() in D:\a\_work\1\s\src\Microsoft.Data.SqlClient\netcore\src\Microsoft\Data\SqlClient\SqlCommand.cs:line 1120
   at Microsoft.Data.SqlClient.SqlRetryLogicProvider.Execute[TResult](Object sender, Func`1 function) in D:\a\_work\1\s\src\Microsoft.Data.SqlClient\src\Microsoft\Data\SqlClient\Reliability\Common\SqlRetryLogicProvider.cs:line 90
   at Microsoft.Data.SqlClient.SqlCommand.RunExecuteReaderWithRetry(CommandBehavior cmdBehavior, RunBehavior runBehavior, Boolean returnStream, String method) in D:\a\_work\1\s\src\Microsoft.Data.SqlClient\netcore\src\Microsoft\Data\SqlClient\SqlCommand.cs:line 1120
   at Microsoft.Data.SqlClient.SqlCommand.ExecuteReader(CommandBehavior behavior) in D:\a\_work\1\s\src\Microsoft.Data.SqlClient\netcore\src\Microsoft\Data\SqlClient\SqlCommand.cs:line 2125
   at Microsoft.Data.SqlClient.ManualTesting.Tests.SqlCommandReliabilityTest.<>c__DisplayClass2_1.<RetryExecuteFail>b__3() in D:\a\_work\1\s\src\Microsoft.Data.SqlClient\tests\ManualTests\SQL\RetryLogic\SqlCommandReliabilityTest.cs:line 44
----- Inner Stack Trace -----
   at Microsoft.Data.SqlClient.SqlCommand.ValidateCommand(Boolean isAsync, String method) in D:\a\_work\1\s\src\Microsoft.Data.SqlClient\netcore\src\Microsoft\Data\SqlClient\SqlCommand.cs:line 5359
   at Microsoft.Data.SqlClient.SqlCommand.RunExecuteReader(CommandBehavior cmdBehavior, RunBehavior runBehavior, Boolean returnStream, TaskCompletionSource`1 completion, Int32 timeout, Task& task, Boolean& usedCache, Boolean asyncWrite, Boolean inRetry, String method) in D:\a\_work\1\s\src\Microsoft.Data.SqlClient\netcore\src\Microsoft\Data\SqlClient\SqlCommand.cs:line 4671
   at Microsoft.Data.SqlClient.SqlCommand.RunExecuteReader(CommandBehavior cmdBehavior, RunBehavior runBehavior, Boolean returnStream, String method) in D:\a\_work\1\s\src\Microsoft.Data.SqlClient\netcore\src\Microsoft\Data\SqlClient\SqlCommand.cs:line 4647
   at Microsoft.Data.SqlClient.SqlCommand.<>c__DisplayClass147_0.<RunExecuteReaderWithRetry>b__0() in D:\a\_work\1\s\src\Microsoft.Data.SqlClient\netcore\src\Microsoft\Data\SqlClient\SqlCommand.cs:line 1120
   at Microsoft.Data.SqlClient.SqlRetryLogicProvider.Execute[TResult](Object sender, Func`1 function) in D:\a\_work\1\s\src\Microsoft.Data.SqlClient\src\Microsoft\Data\SqlClient\Reliability\Common\SqlRetryLogicProvider.cs:line 90
   at Microsoft.Data.SqlClient.SqlCommand.RunExecuteReaderWithRetry(CommandBehavior cmdBehavior, RunBehavior runBehavior, Boolean returnStream, String method) in D:\a\_work\1\s\src\Microsoft.Data.SqlClient\netcore\src\Microsoft\Data\SqlClient\SqlCommand.cs:line 1120
   at Microsoft.Data.SqlClient.SqlCommand.ExecuteReader(CommandBehavior behavior) in D:\a\_work\1\s\src\Microsoft.Data.SqlClient\netcore\src\Microsoft\Data\SqlClient\SqlCommand.cs:line 2125
   at Microsoft.Data.SqlClient.ManualTesting.Tests.SqlCommandReliabilityTest.<>c__DisplayClass2_1.<RetryExecuteFail>b__3() in D:\a\_work\1\s\src\Microsoft.Data.SqlClient\tests\ManualTests\SQL\RetryLogic\SqlCommandReliabilityTest.cs:line 44
View more details on Azure Pipelines