-
Notifications
You must be signed in to change notification settings - Fork 285
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dev | Improved connection timeout #2098
Conversation
DavoudEshtehari
commented
Jul 21, 2023
•
edited
Loading
edited
- Improved the connection timeout accuracy, by involving the IP address resolution and socket connection retry process on Managed SNI.
- Expanded using the timeout timer on managed code.
- Improved connection timeout tests.
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #2098 +/- ##
==========================================
- Coverage 70.98% 70.92% -0.07%
==========================================
Files 305 305
Lines 61818 61844 +26
==========================================
- Hits 43884 43864 -20
- Misses 17934 17980 +46
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
2eb556c
to
1670faa
Compare
Similar to the suggestion I made on the localdb PR, the managed SNI code would benefit from being passed the TimeoutTimer object. The |
src/Microsoft.Data.SqlClient/tests/FunctionalTests/SqlConnectionBasicTests.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Data.SqlClient/tests/FunctionalTests/SqlConnectionBasicTests.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: David Engel <[email protected]>