Experimental OperationStatus

[Wraith2]

I need to test these changes on CI to see if anything breaks that i can't test locally. Please ignore unless you're incredibly bored.

[johnnypham]

You can bring in the changes from #1251 to rerun CI.

[Wraith2]

Thanks @johnnypham, there are still some errors. Cancel doesn't seem to work very well which may be a problem with this set of changes but that can be worked through. There are some total build failures though: C:\Users\dotnet\.nuget\packages\microsoft.sourcelink.common\1.0.0\build\InitializeSourceControlInformation.targets(3,81): Error MSB4022: The result "" of evaluating the value "$(_MicrosoftSourceLinkCommonAssemblyFile)" of the "AssemblyFile" attribute in element <UsingTask> is not valid. which I saw locally and definitely aren't something I've changed.
Overall I think that all that this needs is some attention on the cancel tests, thorough review and possible tweaking. Once that's done we'll have fixed the async string issue.

[BradBarnich]

I tried this build out with the context switch set, and I get an error reading an xml column. With the switch off, it works.

System.Xml.XmlException
Unexpected end tag. Line 1, position 366.
   at System.Xml.XmlTextReaderImpl.Throw(Exception e)
   at System.Xml.XmlTextReaderImpl.Throw(String res, String arg)
   at System.Xml.XmlTextReaderImpl.ParseDocumentContent()
   at System.Xml.XmlTextReaderImpl.Read()
   at System.Xml.XmlWriter.WriteNode(XmlReader reader, Boolean defattr)
   at System.Data.SqlTypes.SqlXml.get_Value()
   at Microsoft.Data.SqlClient.SqlCachedBuffer.ToString()
   at Microsoft.Data.SqlClient.SqlBuffer.get_Value()
   at Microsoft.Data.SqlClient.SqlDataReader.GetValueFromSqlBufferInternal(SqlBuffer data, _SqlMetaData metaData)
   at Microsoft.Data.SqlClient.SqlDataReader.GetValueInternal(Int32 i)
   at Microsoft.Data.SqlClient.SqlDataReader.GetValue(Int32 i)

[Wraith2]

Interesting, can you provide me with a minimal reproduction to debug against?

[BradBarnich]

Here you go

sql-xml-failure.zip

[Wraith2]

Ok. That failure is sort of expected because I haven't tested that route through the library. Handling the xml type is totally different to handing strings or binary chunks and it just hasn't been reviewed. That doesn't mean it can't be made to work but at the moment I just don't have the energy to put into it, it's taken me a year to get this far and I need a break from tracking down async in this library.