-
Notifications
You must be signed in to change notification settings - Fork 25.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update getting-started-with-swashbuckle.md #31441
Merged
Merged
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
908e433
Update getting-started-with-swashbuckle.md
Rick-Anderson 469824c
Update aspnetcore/tutorials/getting-started-with-swashbuckle.md
Rick-Anderson 5a50537
Update aspnetcore/tutorials/getting-started-with-swashbuckle.md
Rick-Anderson 9e7c65e
Apply suggestions from code review
Rick-Anderson 189eb93
Update getting-started-with-swashbuckle.md
tdykstra 52af9e7
Update getting-started-with-swashbuckle.md
Rick-Anderson 5aa38a5
Update getting-started-with-swashbuckle.md
Rick-Anderson c529af9
Update getting-started-with-swashbuckle.md
Rick-Anderson 7a229f6
Update getting-started-with-swashbuckle.md
Rick-Anderson f18d6e9
Update getting-started-with-swashbuckle.md
tdykstra File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about changing the file metadata from
monikerRange: '>= aspnetcore-3.1'
to
monikerRange: '>= aspnetcore-3.1 < aspnetcore-8.0'
That would at least get it out of the TOC.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That was my first try, and at least in the review URL, it still showed up in the TOC.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tdykstra take a look, it still shows up in the TOC.