Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update getting-started-with-swashbuckle.md #31441

Merged
merged 10 commits into from
Jan 17, 2024
Merged

Update getting-started-with-swashbuckle.md #31441

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
908e433
Update getting-started-with-swashbuckle.md
Rick-Anderson Jan 12, 2024
469824c
Update aspnetcore/tutorials/getting-started-with-swashbuckle.md
Rick-Anderson Jan 12, 2024
5a50537
Update aspnetcore/tutorials/getting-started-with-swashbuckle.md
Rick-Anderson Jan 13, 2024
9e7c65e
Apply suggestions from code review
Rick-Anderson Jan 16, 2024
189eb93
Update getting-started-with-swashbuckle.md
tdykstra Jan 16, 2024
52af9e7
Update getting-started-with-swashbuckle.md
Rick-Anderson Jan 16, 2024
5aa38a5
Update getting-started-with-swashbuckle.md
Rick-Anderson Jan 16, 2024
c529af9
Update getting-started-with-swashbuckle.md
Rick-Anderson Jan 16, 2024
7a229f6
Update getting-started-with-swashbuckle.md
Rick-Anderson Jan 16, 2024
f18d6e9
Update getting-started-with-swashbuckle.md
tdykstra Jan 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion aspnetcore/tutorials/getting-started-with-swashbuckle.md
View file
Open in desktop
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about changing the file metadata from

monikerRange: '>= aspnetcore-3.1'

to

monikerRange: '>= aspnetcore-3.1 < aspnetcore-8.0'

That would at least get it out of the TOC.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about changing the file metadata from

monikerRange: '>= aspnetcore-3.1'

to

monikerRange: '>= aspnetcore-3.1 < aspnetcore-8.0'

That would at least get it out of the TOC.

That was my first try, and at least in the review URL, it still showed up in the TOC.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tdykstra take a look, it still shows up in the TOC.

Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ uid: tutorials/get-started-with-swashbuckle
---
# Get started with Swashbuckle and ASP.NET Core

:::moniker range=">= aspnetcore-6.0"
:::moniker range=">= aspnetcore-6.0 < aspnetcore-8.0"
Rick-Anderson marked this conversation as resolved.
Show resolved Hide resolved

There are three main components to Swashbuckle:

Expand Down