-
Notifications
You must be signed in to change notification settings - Fork 25.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update getting-started-with-swashbuckle.md #31441
Conversation
@tdykstra I'd rather just hide the topic for .NET 8 and higher, but that doesn't work. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One idea for you to consider.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about changing the file metadata from
monikerRange: '>= aspnetcore-3.1'
to
monikerRange: '>= aspnetcore-3.1 < aspnetcore-8.0'
That would at least get it out of the TOC.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about changing the file metadata from
monikerRange: '>= aspnetcore-3.1'
to
monikerRange: '>= aspnetcore-3.1 < aspnetcore-8.0'
That would at least get it out of the TOC.
That was my first try, and at least in the review URL, it still showed up in the TOC.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tdykstra take a look, it still shows up in the TOC.
With "< aspnetcore-8.0" in the file metadata you don't need the < aspnetcore-8.0 block in the text. It always switches to 7.0 when you try to go to 8.0. |
It's still not a great user experience if you land on that page so I added the warning back. |
Can you fix the file? Just edit it. |
OK I think it's ready to go now:
|
|
Fixes #31437
Internal previews