This repository has been archived by the owner on Apr 16, 2024. It is now read-only.
[Fix] [doom-dashboard.lua #345]
#346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(Bug Fixes) - changes made following [`dashboard-nvim`](https://github.com/glepnir/dashboard-nvim) Vimscript -> Lua rewrite - add `local db = require("dashboard")` - rewrite (Vimscript) `vim.g.dashboard_custom_section` -> (Lua) `db.custom_center` - rewrite (Vimscript) `vim.g.dashboard_custom_footer` -> (Lua) `db.custom_footer` - rewrite (Vimscript) `vim.g.dashboard_custom_header` -> (Lua) `db.custom_header` - fix `custom_header` support for when user sets `config.doom.dashboard_custom_header` - fix/update header colors (highlight groups)
NTBBloodbath
added
branch: main
|
Hi @NTBBloodbath , I reviewed the failing check and it appears to be related to pre-existing code found here and here Let me know how I may assist or how you'd like to proceed? Thanks! |
|
I combine your changes in this NextAlone@4cd7905 Ohh, this is for next branch, not main branch |
|
the lua dir structure has been modified |
|
Just tested it all out, seems to be working well. Thanks for the contribution! |
@connorgmeehan maybe you see this for next branch |
|
Hey nextalone, it should be merged in #353 |
Oops i forgot the pull request |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Bug Fixes) - changes made following
dashboard-nvimVimscript -> Lua rewritelocal db = require("dashboard")vim.g.dashboard_custom_section-> (Lua)db.custom_centervim.g.dashboard_custom_footer-> (Lua)db.custom_footervim.g.dashboard_custom_header-> (Lua)db.custom_headercustom_headersupport for when user setsconfig.doom.dashboard_custom_header