Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GHI #32 Implement complete public API #34

Merged
merged 319 commits into from
Oct 28, 2024
Merged

GHI #32 Implement complete public API #34

merged 319 commits into from
Oct 28, 2024

Conversation

doodspav
Copy link
Owner

@doodspav doodspav commented Jun 28, 2024 •
edited
Loading

Implemented full public API with 100% good coverage (not including any implementations) and all requirements tested.
Currently, only the null implementation exists.

doodspav added 30 commits May 19, 2024 18:21
@doodspav
GHI #32 Add WILL_FAIL_IF_ANY_NOT
317c841
@doodspav
GHI #32 Remove WILL_FAIL_IF_ALL_SUCCEED_FALSE
3a50a69
@doodspav
GHI #32 Add COMPILER_HAS_STDINT and PATOMIC_HAS_STDINT
6d91bd1
@doodspav
GHI #32 Make use of WILL_FAIL_IF_ANY_NOT
a06e024
@doodspav
GHI #32 Minor fix to COMPILER_HAS_STDDEF_INTPTR_EXTN
2e01f44
@doodspav
GHI #32 Replace empty set() with unset()
cfe5390
@doodspav
GHI #32 Add empty stdint.h
e2ce8c8
@doodspav
GHI #32 Add llong, int128, and intptr to stdint.h
e4cc0ca
@doodspav
GHI #32 Implement align.c
c4a64fc
@doodspav
GHI #32 Remove warning guard CMake option PATOMIC_INCLUDES_WITH_SYSTEM
56f0eb8 
Header includes always use SYSTEM now
@doodspav
GHI #32 Rename PATOMIC_INSTALL_CMAKEDIR to CMAKE_INSTALL_CMAKEDIR
27c1b86
@doodspav
GHI #32 Rename PATOMIC_BUILD_SHARED to PATOMIC_BUILD_SHARED_LIBS
1a39662
@doodspav
GHI #32 Add FULL paths for cache variables
a537860
@doodspav
GHI #32 List include sources in src/ CML not root CML
220d99b
@doodspav
GHI #32 Prevent warning about old GNUInstallDirs_get_absolute_install…
15dff71 
…_dir
@doodspav
GHI #32 Update issues in include/ from CLion Nova additional findings
9848e39
@doodspav
GHI #32 Update issues in src/ from CLion Nova additional findings
ae750b4
@doodspav
GHI #32 Improve CMake except for in /test
385f25b
@doodspav
GHI #32 Improve CMake in /test
aa15b23
@doodspav
GHI #32 Add gtest include dir to include target
191ba9d
@doodspav
GHI #32 Minor missed thing in CreateTest
78f05ec
@doodspav
GHI #32 Remove unnecessary include
122224e
@doodspav
GHI #32 Add const to align.c
9567766
@doodspav
GHI #32 Rename PATOMIC_VERSION to PATOMIC_VERSION_STRING for clarity
5d646db
@doodspav
GHI #32 Add patomic_version_string() function
66908bb
@doodspav
GHI #32 Fix PATOMIC_VERSION_COMPATIBLE_WITH
5206259
@doodspav
GHI #32 Warn about SemVer limitations (major version 0)
66925eb
@doodspav
GHI #32 Improve docs in align.h
c9f736c
@doodspav
GHI #32 Declare all align.cpp test cases
67c621d
@doodspav
GHI #32 Add common test headers
4ca3d8c
doodspav added 26 commits July 13, 2024 16:17
@doodspav
GHI #32 Fix UB in test
4df2f76
@doodspav
GHI #32 Fix merging artifacts
6d8efeb
@doodspav
GHI #32 Skip test when running under ubsan
f3f9253
@doodspav
GHI #32 Only use ExitedWithCode(3) for msvc
c9a71b5
@doodspav
GHI #32 Split death.cpp into h/cpp pair [skip ci]
53949f5
@doodspav
GHI #32 Remove use of gmock in BTs [skip ci]
6521070
@doodspav
GHI #32 Debug mingw version
8daa971
@doodspav
GHI #32 Fix KilledByAbort to work with both Windows Runtimes
91d48fa
@doodspav
GHI #32 Use KilledByAbortPredicateType in impl too
d7aae6c
@doodspav
GHI #32 Set LLVM_PROFILE_FILE for tests
60be1a8
@doodspav
GHI #32 Remove working directory from tests
b691ef1
@doodspav
GHI #32 Skip hppa-ubuntu-gcc-shared-coverage
42621ed
@doodspav
GHI #32 Fix skip
1c4c0c5
@doodspav
GHI #32 Fix skip (2)
30a7be9
@doodspav
GHI #32 Remove EXCL_LINE comments for now [skip ci]
650a731
@doodspav
GHI #32 Add UT for patomic_internal_compare_align
3c55b2c
@doodspav
GHI #32 Change UtApiAlign to UtInternalAlign [skip ci]
688bb60
@doodspav
GHI #32 Add Wno-reserved-identifier to clang for C
50e8b87
@doodspav
GHI #32 Remove trailing ;
c62e968
@doodspav
GHI #32 Add -Wno-documentation-unknown-command to clang for C
0bf2442
@doodspav
GHI #32 Check coverage for /include too
bc5606a
@doodspav
GHI #32 Add missing quote
04e5b38
@doodspav
GHI #32 Ignore errors
65ef147
@doodspav
GHI #32 Ignore errors (2)
a3bfad0
@doodspav
GHI #32 Change coverage limits to 50%
d683345
@doodspav
GHI #32 Disable coverage for now
e93cc3d
GabrielRavier
GabrielRavier approved these changes Oct 28, 2024
View reviewed changes
Copy link
Collaborator

@GabrielRavier GabrielRavier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not actually reviewed but approving as asked.

@doodspav doodspav merged commit fb23f02 into develop Oct 28, 2024
256 checks passed
@doodspav doodspav deleted the feature/ghi-32-add-public-api branch October 28, 2024 00:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GabrielRavier GabrielRavier GabrielRavier approved these changes

@ii64 ii64 Awaiting requested review from ii64

Assignees

@doodspav doodspav

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Define public API (with default impl)
2 participants
@doodspav @GabrielRavier