Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Define public API (with default impl) #32

Closed
doodspav opened this issue Mar 1, 2024 · 0 comments · Fixed by #34
Closed

Define public API (with default impl) #32

doodspav opened this issue Mar 1, 2024 · 0 comments · Fixed by #34
Assignees
@doodspav
Labels
user story User story

Comments

@doodspav
Copy link
Owner

doodspav commented Mar 1, 2024 •
edited
Loading

To Do:

  • bring over all public API from devel branch

  • document public API with doxygen style comments, and try to come up with an extra doxygen attribute to link public api to requirements

  • implement public API minimally (i.e. return nullptr or whatever as long as it meets requirements)

  • write BTs and UTs that cover as much as possible
@doodspav doodspav added the user story User story label Mar 1, 2024
@doodspav doodspav self-assigned this Mar 1, 2024
doodspav added a commit that referenced this issue Mar 1, 2024
@doodspav
GHI #32 Add align.h header
fab548d
doodspav added a commit that referenced this issue Mar 5, 2024
@doodspav
GHI #32 Add ids.h header
46610a0
doodspav added a commit that referenced this issue Mar 6, 2024
@doodspav
GHI #32 Add memory_order.h header
a1e5685
doodspav added a commit that referenced this issue Mar 6, 2024
@doodspav
GHI #32 Add options.h header
05f0b71
doodspav added a commit that referenced this issue May 4, 2024
@doodspav
GHI #32 Improve align.h doxygen comments on struct members.
2a25858
doodspav added a commit that referenced this issue May 4, 2024
@doodspav
GHI #32 Add transaction.h
4886a90
doodspav added a commit that referenced this issue May 6, 2024
@doodspav
GHI #32 Add ops/implicit.h
a648206
doodspav added a commit that referenced this issue May 6, 2024
@doodspav
GHI #32 Add extern C to ops/implicit.h
a98d367
doodspav added a commit that referenced this issue May 6, 2024
@doodspav
GHI #32 Clarify cmpxchg weak vs strong
70a5b9c
doodspav added a commit that referenced this issue May 7, 2024
@doodspav
GHI #32 Add explicit.h opsigs
3fd41f5
doodspav added a commit that referenced this issue May 7, 2024
@doodspav
GHI #32 Add memory order parameter to explicit opsigs
e67a13e
doodspav added a commit that referenced this issue May 7, 2024
@doodspav
GHI #32 Opsig fetch should return void
ab7f4a1
doodspav added a commit that referenced this issue May 7, 2024
@doodspav
GHI #32 Add ops_t to explicit.h
40747d6
doodspav added a commit that referenced this issue May 7, 2024
@doodspav
GHI #32 Mark explicit.h with extern "C"
073138a
doodspav added a commit that referenced this issue May 8, 2024
@doodspav
GHI #32 Add basic opsigs for ops/transaction.h
95a10bb
doodspav added a commit that referenced this issue May 8, 2024
@doodspav
GHI #32 Make cmpxchg transaction have fallback
c797bb3
doodspav added a commit that referenced this issue May 10, 2024
@doodspav
GHI #32 Add special transaction opsigs
93b6c7a
doodspav added a commit that referenced this issue May 10, 2024
@doodspav
GHI #32 Add flag transaction opsigs
bf7fb92
doodspav added a commit that referenced this issue May 10, 2024
@doodspav
GHI #32 Add raw transaction opsigs
9461a55
doodspav added a commit that referenced this issue May 10, 2024
@doodspav
GHI #32 Add transaction ops structs
f756088
doodspav added a commit that referenced this issue May 10, 2024
@doodspav
GHI #32 Add extern C to transaction ops
184bc0a
doodspav added a commit that referenced this issue May 10, 2024
@doodspav
GHI #32 Add opcat and opkind enums
77489a4
doodspav added a commit that referenced this issue May 10, 2024
@doodspav
GHI #32 Add implicit feature check functions
a5561f6
doodspav added a commit that referenced this issue May 10, 2024
@doodspav
GHI #32 Add explicit and transaction feature check functions
4b46e70
doodspav added a commit that referenced this issue May 10, 2024
@doodspav
GHI #32 Add extern "C" to feature_check.h
0150ad3
doodspav added a commit that referenced this issue May 11, 2024
@doodspav
GHI #32 Do most of patomic.h
732dc31
doodspav added a commit that referenced this issue May 11, 2024
@doodspav
GHI #32 Add transaction creation to patomic.h
12f97d6
doodspav added a commit that referenced this issue May 11, 2024
@doodspav
GHI #32 Mark patomic.h as extern C
9bf28e5
doodspav added a commit that referenced this issue Jul 13, 2024
@doodspav
GHI #32 Migrate actions/{upload, download} from v3 to v4
3ff362e
doodspav added a commit that referenced this issue Jul 13, 2024
@doodspav
GHI #32 Change upload artifact to use UNIQUE_ID instead of UNIQUE_NAME
04c6546
doodspav added a commit that referenced this issue Jul 13, 2024
@doodspav
GHI #32 Fix UB in test
4df2f76
doodspav added a commit that referenced this issue Jul 13, 2024
@doodspav
GHI #32 Fix merging artifacts
6d8efeb
doodspav added a commit that referenced this issue Jul 13, 2024
@doodspav
GHI #32 Skip test when running under ubsan
f3f9253
doodspav added a commit that referenced this issue Jul 13, 2024
@doodspav
GHI #32 Only use ExitedWithCode(3) for msvc
c9a71b5
doodspav added a commit that referenced this issue Jul 13, 2024
@doodspav
GHI #32 Split death.cpp into h/cpp pair [skip ci]
53949f5
doodspav added a commit that referenced this issue Jul 13, 2024
@doodspav
GHI #32 Remove use of gmock in BTs [skip ci]
6521070
doodspav added a commit that referenced this issue Jul 13, 2024
@doodspav
GHI #32 Debug mingw version
8daa971
doodspav added a commit that referenced this issue Jul 13, 2024
@doodspav
GHI #32 Fix KilledByAbort to work with both Windows Runtimes
91d48fa
doodspav added a commit that referenced this issue Jul 13, 2024
@doodspav
GHI #32 Use KilledByAbortPredicateType in impl too
d7aae6c
doodspav added a commit that referenced this issue Jul 13, 2024
@doodspav
GHI #32 Set LLVM_PROFILE_FILE for tests
60be1a8
doodspav added a commit that referenced this issue Jul 14, 2024
@doodspav
GHI #32 Remove working directory from tests
b691ef1
doodspav added a commit that referenced this issue Jul 14, 2024
@doodspav
GHI #32 Skip hppa-ubuntu-gcc-shared-coverage
42621ed
doodspav added a commit that referenced this issue Jul 14, 2024
@doodspav
GHI #32 Fix skip
1c4c0c5
doodspav added a commit that referenced this issue Jul 14, 2024
@doodspav
GHI #32 Fix skip (2)
30a7be9
doodspav added a commit that referenced this issue Jul 14, 2024
@doodspav
GHI #32 Remove EXCL_LINE comments for now [skip ci]
650a731
doodspav added a commit that referenced this issue Jul 14, 2024
@doodspav
GHI #32 Add UT for patomic_internal_compare_align
3c55b2c
doodspav added a commit that referenced this issue Jul 14, 2024
@doodspav
GHI #32 Change UtApiAlign to UtInternalAlign [skip ci]
688bb60
doodspav added a commit that referenced this issue Jul 14, 2024
@doodspav
GHI #32 Add Wno-reserved-identifier to clang for C
50e8b87
doodspav added a commit that referenced this issue Jul 14, 2024
@doodspav
GHI #32 Remove trailing ;
c62e968
doodspav added a commit that referenced this issue Jul 14, 2024
@doodspav
GHI #32 Add -Wno-documentation-unknown-command to clang for C
0bf2442
doodspav added a commit that referenced this issue Jul 14, 2024
@doodspav
GHI #32 Check coverage for /include too
bc5606a
doodspav added a commit that referenced this issue Jul 14, 2024
@doodspav
GHI #32 Add missing quote
04e5b38
doodspav added a commit that referenced this issue Jul 14, 2024
@doodspav
GHI #32 Ignore errors
65ef147
doodspav added a commit that referenced this issue Jul 14, 2024
@doodspav
GHI #32 Ignore errors (2)
a3bfad0
doodspav added a commit that referenced this issue Oct 27, 2024
@doodspav
GHI #32 Change coverage limits to 50%
d683345
doodspav added a commit that referenced this issue Oct 27, 2024
@doodspav
GHI #32 Disable coverage for now
e93cc3d
doodspav added a commit that referenced this issue Oct 28, 2024
@doodspav
GHI #32 Implement complete public API (#34)
fb23f02 
Implemented full public API with BTs on the API and UTs on the whole existing codebase.
Currently, only the null implementation exists.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@doodspav doodspav

Labels
user story User story
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

GHI #32 Implement complete public API doodspav/patomic
1 participant
@doodspav