Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix for using git SSH credentials #80

Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 12 additions & 3 deletions domino_data/_feature_store/sync.py
Original file line number Diff line number Diff line change
Expand Up @@ -206,9 +206,18 @@ def feature_store_sync(
result = FeatureStoreSyncResult.FAILURE
lock(feature_store_id, max_retries)
try:
pull_repo(repo, branch_name)
run_feast_apply(repo_path_str=repo_path_str, skip_source_validation=skip_source_validation)
push_to_git(repo)
# Feature store syncing is going to be run in a domino job. Turn off it
# to avoid the user interaction on host authentication. Feast git repo
# has already been pulled and mounted as a volume to the job pod, so the host
# can be trusted.
git_ssh_cmd = "ssh -o StrictHostKeyChecking=no"
with repo.git.custom_environment(GIT_SSH_COMMAND=git_ssh_cmd):
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't affect GIT connection using personal access token.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wow great job!

pull_repo(repo, branch_name)
run_feast_apply(
repo_path_str=repo_path_str, skip_source_validation=skip_source_validation
)
push_to_git(repo)

update_feature_views(repo.head.object.hexsha, repo_path_str)
result = FeatureStoreSyncResult.SUCCESS
logger.info("Finished feature store syncing.")
Expand Down