Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix for using git SSH credentials #80

Conversation

ddl-joyce-zhao
Copy link
Contributor

@ddl-joyce-zhao ddl-joyce-zhao commented Dec 23, 2022

Description

Feature store sync script fix for using Git SSH credentials

https://dominodatalab.atlassian.net/browse/DOM-43054

Related Issue

The sync script fails to run in the Domino job because the interactive question for host check can't be answered

Type of Change

  • 📚 Examples / docs / tutorials / dependencies update
  • 🔧 Bug fix (non-breaking change which fixes an issue)
  • 🥂 Improvement (non-breaking change which improves an existing feature)
  • 🚀 New feature (non-breaking change which adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to change)
  • 🔐 Security fix

Checklist

  • I've read the CONTRIBUTING.md guide.
  • I've updated the code style using make codestyle.
  • I've written tests for all new methods and classes that I created.
  • I've written the docstring in Google format for all the methods and classes that I used.

@github-actions
Copy link

github-actions bot commented Dec 23, 2022

✅ Result of Pytest Coverage

---------- coverage: platform linux, python 3.10.9-final-0 -----------

Name Stmts Miss Cover
domino_data/init.py 7 2 71%
domino_data/_feature_store/init.py 0 0 100%
domino_data/_feature_store/client.py 41 3 93%
domino_data/_feature_store/exceptions.py 9 0 100%
domino_data/_feature_store/git.py 43 1 98%
domino_data/_feature_store/run.py 16 16 0%
domino_data/_feature_store/sync.py 98 9 91%
domino_data/auth.py 84 12 86%
domino_data/configuration_gen.py 158 0 100%
domino_data/data_sources.py 265 15 94%
domino_data/logging.py 11 0 100%
domino_data/training_sets/init.py 0 0 100%
domino_data/training_sets/client.py 126 10 92%
domino_data/training_sets/model.py 42 0 100%
TOTAL 900 68 92%

~ 54 passed in 20.22s ~

# has already been pulled and mounted as a volume to the job pod, so the host
# can be trusted.
git_ssh_cmd = "ssh -o StrictHostKeyChecking=no"
with repo.git.custom_environment(GIT_SSH_COMMAND=git_ssh_cmd):
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't affect GIT connection using personal access token.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wow great job!

@ddl-joyce-zhao ddl-joyce-zhao merged commit 47e0085 into main Jan 3, 2023
@ddl-joyce-zhao ddl-joyce-zhao deleted the ddl-joyce-zhao.DOM-43054.fix-job-sync-issue-with-SSH-credentials branch January 3, 2023 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants