check codestyle and mypy, fix test

domino_data/_feature_store/client.py

@@ -1,5 +1,5 @@
 """Feature Store module."""
-from typing import List, Optional, cast
+from typing import Any, List, Optional, cast
 
 import json
 import os
@@ -104,7 +104,7 @@ def unlock(self, unlock_request: UnlockFeatureStoreRequest) -> bool:
         return False if response.parsed is None else response.parsed
 
 
-def _raise_response_exn(response: Response, msg: str):
+def _raise_response_exn(response: Response[Any], msg: str) -> None:
     try:
         response_json = json.loads(response.content.decode("utf8"))
         server_msg = response_json.get("errors")

domino_data/_feature_store/sync.py

@@ -17,6 +17,7 @@
 )
 
 from ..logging import logger
+from ..types import UNSET
 from .client import FeatureStoreClient
 from .exceptions import FeastRepoError, FeatureStoreLockError
 from .git import pull_repo, push_to_git
@@ -110,7 +111,7 @@ def update_feature_views(commit_id: str, repo_path: str) -> None:
                 for x, y in zip(fv.entities, fv.entity_columns)
             ],
             features=[Feature(name=f.name, dtype=str(f.dtype)) for f in fv.features],
-            ttl=None if fv.ttl is None else int(fv.ttl.total_seconds() * 1000),
+            ttl=UNSET if fv.ttl is None else int(fv.ttl.total_seconds() * 1000),
             tags=FeatureViewRequestTags.from_dict(fv.tags),
         )
         request_input.append(feature_v)
@@ -174,8 +175,8 @@ def feature_store_sync(
     repo_path_str: str,
     branch_name: str,
     max_retries: int,
-    skip_source_validation=False,
-):
+    skip_source_validation: bool = False,
+) -> None:
     """run feature store syncing
     Args:
         feature_store_id: the feature store domino id

pyproject.toml

@@ -118,7 +118,7 @@ color_output = true
 
 [tool.mypy]
 # mypy configurations: https://mypy.readthedocs.io/en/latest/config_file.html#using-a-pyproject-toml-file
-exclude = 'datasource_api_client/|domino_data/training_sets/|.venv/|tests/'
+exclude = 'datasource_api_client/|domino_data/training_sets/|.venv/|tests/|dist/'
 python_version = 3.8
 pretty = true
 show_traceback = true

tests/feature_store/test_sync.py

@@ -6,7 +6,7 @@
 import httpx
 import pytest
 from feast import FeatureStore, repo_config, repo_operations
-from git import Repo
+from git.repo import Repo
 
 from domino_data._feature_store import sync
 from domino_data._feature_store.exceptions import (
@@ -63,8 +63,12 @@ def test_sync(feast_repo_root_dir, env, respx_mock, datafx):
         return_value=httpx.Response(200, content="true"),
     )
 
+    repo_mock = MagicMock()
+    repo_mock.head.object.hexsha = "123456"
+
     FeatureStore.__new__ = MagicMock()
     Repo.__new__ = MagicMock()
+    Repo.__new__.return_value = repo_mock
     repo_config.load_repo_config = MagicMock()
     repo_operations.cli_check_repo = MagicMock()
     repo_operations.apply_total = MagicMock()