pyproject remove optional

dominodatalab · Dec 7, 2022 · 20aacf6 · 20aacf6
1 parent 9343f34
commit 20aacf6
Show file tree

Hide file tree

Showing 6 changed files with 4 additions and 7 deletions.
diff --git a/domino_data/_feature_store/sync.py b/domino_data/_feature_store/sync.py
@@ -115,8 +115,6 @@ def update_feature_views(commit_id: str, repo_path: str) -> None:
         )
         request_input.append(feature_v)
 
-    # TODO update the API to include the commit id so that feature views
-    # and commit id can be updated to domino in one call
     client = FeatureStoreClient()
     client.post_feature_views(request_input, commit_id)
     logger.info("Feature Views successfully synced.")

diff --git a/domino_data/data_sources.py b/domino_data/data_sources.py
@@ -227,6 +227,7 @@ def load_oauth_credentials() -> Dict[str, str]:
             jwt = get_jwt_token(token_url)
         except httpx.HTTPStatusError:
             logger.opt(exception=True).warning("Failed to get token from sidecar container API")
+            pass
         else:
             return {CredElem.TOKEN.value: jwt}
 

diff --git a/poetry.lock b/poetry.lock
diff --git a/pyproject.toml b/pyproject.toml
@@ -76,9 +76,6 @@ sphinx-rtd-theme = "^0.5.2"
 types-PyYAML = "^6.0.4"
 types-python-dateutil = "^2.8.19.4"
 
-[tool.poetry.group.featurestore]
-optional = true
-
 [tool.poetry.group.featurestore.dependencies]
 feast = "^0.26.0"
 GitPython = "^3.1.29"

diff --git a/requirements.txt b/requirements.txt
@@ -5,7 +5,7 @@ bson==0.5.10 ; python_version >= "3.8" and python_version < "4.0"
 certifi==2022.9.24 ; python_version >= "3.8" and python_version < "4.0"
 colorama==0.4.6 ; python_version >= "3.8" and python_version < "4.0" and sys_platform == "win32"
 h11==0.14.0 ; python_version >= "3.8" and python_version < "4.0"
-httpcore==0.16.1 ; python_version >= "3.8" and python_version < "4.0"
+httpcore==0.16.2 ; python_version >= "3.8" and python_version < "4.0"
 httpx==0.23.1 ; python_version >= "3.8" and python_version < "4.0"
 idna==3.4 ; python_version >= "3.8" and python_version < "4.0"
 loguru==0.5.3 ; python_version >= "3.8" and python_version < "4.0"

diff --git a/tests/conftest.py b/tests/conftest.py
@@ -5,6 +5,7 @@
 
 import pyarrow
 import pytest
+from _pytest.logging import caplog as _caplog
 from loguru import logger
 
 # TODO This method is deprecated and should be refactored using `env`